Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(27)

Issue 2496433002: Rename --enable-webapk command line flag to --enable-improved-a2hs (Closed)

Created:
2 years, 7 months ago by pkotwicz
Modified:
2 years, 7 months ago
Reviewers:
Ilya Sherman, gone
CC:
chromium-reviews, dominickn+watch_chromium.org, jam, darin-cc_chromium.org, asvitkine+watch_chromium.org, agrieve+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename --enable-webapk command line flag to --enable-improved-a2hs The new name is more consistent with the new description in chrome://flags introduced in https://codereview.chromium.org/2485513002/ BUG=None R=dfalcantara, isherman TBR=sievers For comment change in ChildProcessServiceImpl.java Committed: https://crrev.com/c46fb150c4714312524910a324d15fe409b8a781 Cr-Commit-Position: refs/heads/master@{#431602}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Merge branch 'master' into rename_flag #

Total comments: 1

Patch Set 3 : Merge branch 'master' into rename_flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
pkotwicz
Dan can you please take a look?
2 years, 7 months ago (2016-11-10 02:50:27 UTC) #2
gone
https://codereview.chromium.org/2496433002/diff/1/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): https://codereview.chromium.org/2496433002/diff/1/chrome/common/chrome_switches.cc#newcode1044 chrome/common/chrome_switches.cc:1044: const char kEnableWebApk[] = "enable-improved-a2hs"; You need to update ...
2 years, 7 months ago (2016-11-10 18:12:08 UTC) #3
pkotwicz
Dan can you please take another looK?
2 years, 7 months ago (2016-11-10 19:49:47 UTC) #4
gone
lgtm https://codereview.chromium.org/2496433002/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2496433002/diff/20001/tools/metrics/histograms/histograms.xml#newcode91122 tools/metrics/histograms/histograms.xml:91122: + <int value="1496571153" label="enable-improved-a2hs"/> You're not supposed to ...
2 years, 7 months ago (2016-11-10 19:54:53 UTC) #5
pkotwicz
isherman@ for tools/metrics OWNERS
2 years, 7 months ago (2016-11-10 20:53:09 UTC) #7
Ilya Sherman
histograms.xml lgtm
2 years, 7 months ago (2016-11-10 21:03:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2496433002/40001
2 years, 7 months ago (2016-11-11 15:54:07 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/302320)
2 years, 7 months ago (2016-11-11 16:02:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2496433002/40001
2 years, 7 months ago (2016-11-11 18:22:04 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
2 years, 7 months ago (2016-11-11 18:29:10 UTC) #18
commit-bot: I haz the power
2 years, 7 months ago (2016-11-11 19:00:10 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c46fb150c4714312524910a324d15fe409b8a781
Cr-Commit-Position: refs/heads/master@{#431602}

Powered by Google App Engine
This is Rietveld 408576698