Delete all of the video_processing module but the denoiser code.

Delete all of the video_processing module but the denoiser code.

It is unused since cl https://codereview.webrtc.org/2386573002.

The new denoiser implementation and its tests are kept for now. This
code is also unused, but there are some plans to take this code into
use in the not too distant future.

BUG=None

Committed: https://crrev.com/13d38fbe904cd99acebf77068e93df34725eeb47
Cr-Commit-Position: refs/heads/master@{#15338}

[nisse-webrtc, 2016-11-14 10:48:58]

nisse@webrtc.org changed reviewers:
+ mflodman@webrtc.org, perkj@webrtc.org

[nisse-webrtc, 2016-11-14 10:48:59]

The video processing module is no longer used.

Not sure where else to hook in the denoiser if/when we want to use it, for now
it's left unchanged.

I could file a bug to associate with this cl, is that helpful?

I suspect that the file resources/foremanColorEnhanced_cif_short.yuv (9MB) is
somewhat related, should we delete that too? I'm not sure how the fetching of
resource files work or where they are stored.

[perkj_webrtc, 2016-11-14 11:39:16]

vie_encoder lgtm, thanks.

The rest,I will leave to mflodman to find a suitable reviewer/take decision.

[nisse-webrtc, 2016-11-25 15:22:44]

On 2016/11/14 11:39:16, perkj_webrtc wrote:
> vie_encoder lgtm, thanks.
> 
> The rest,I will leave to mflodman to find a suitable reviewer/take decision.

Magnus, ping?

[mflodman, 2016-11-30 13:42:39]

mflodman@webrtc.org changed reviewers:
+ stefan@webrtc.org

[mflodman, 2016-11-30 13:42:39]

Two minor comments, then LGTM from my side since the new denoiser wire-up has
already been removed.

It would be good to get sign off from Stefan as a VPM owner.

https://codereview.webrtc.org/2496153002/diff/1/webrtc/modules/video_processi...
File webrtc/modules/video_processing/util/denoiser_filter.h (right):

https://codereview.webrtc.org/2496153002/diff/1/webrtc/modules/video_processi...
webrtc/modules/video_processing/util/denoiser_filter.h:18: // #include
"webrtc/modules/video_processing/include/video_processing_defines.h"
Remove?

https://codereview.webrtc.org/2496153002/diff/1/webrtc/modules/video_processi...
File webrtc/modules/video_processing/util/noise_estimation.h (right):

https://codereview.webrtc.org/2496153002/diff/1/webrtc/modules/video_processi...
webrtc/modules/video_processing/util/noise_estimation.h:17: // #include
"webrtc/modules/video_processing/include/video_processing_defines.h"
Remove?

[stefan-webrtc, 2016-11-30 13:49:32]

lgtm, good that we're keeping the denoiser and the frame preprocessor for now.

[nisse-webrtc, 2016-11-30 14:00:45]

On 2016/11/30 13:49:32, stefan-webrtc (holmer) wrote:
> lgtm, good that we're keeping the denoiser and the frame preprocessor for now.

Hmm, my intention was to delete the frame preprocessor too. It's also unused,
and its VideoFrame member variables depend on the VideoFrame default constructor
which I want to delete. So if the code is kept, it needs some refactoring work.
This cl drops the frame_preprocessor.* from video_processing/BUILD.gn, but
accidentally leaves the source files around.

[nisse-webrtc, 2016-11-30 14:02:04]

https://codereview.webrtc.org/2496153002/diff/1/webrtc/modules/video_processi...
File webrtc/modules/video_processing/util/denoiser_filter.h (right):

https://codereview.webrtc.org/2496153002/diff/1/webrtc/modules/video_processi...
webrtc/modules/video_processing/util/denoiser_filter.h:18: // #include
"webrtc/modules/video_processing/include/video_processing_defines.h"
On 2016/11/30 13:42:39, mflodman wrote:
> Remove?

Ooops, this and the other one are left-overs. Removed.

[nisse-webrtc, 2016-11-30 14:21:54]

On 2016/11/30 14:00:45, nisse-webrtc wrote:
> On 2016/11/30 13:49:32, stefan-webrtc (holmer) wrote:
> > lgtm, good that we're keeping the denoiser and the frame preprocessor for
now.
> 
> Hmm, my intention was to delete the frame preprocessor too. It's also unused,
> and its VideoFrame member variables depend on the VideoFrame default
constructor
> which I want to delete. So if the code is kept, it needs some refactoring
work.
> This cl drops the frame_preprocessor.* from video_processing/BUILD.gn, but
> accidentally leaves the source files around.

Deleting frame_preprocessor.[cc,h] too, after offline chat with Stefan. 
video_denoiser.[cc,h] is kept.

[nisse-webrtc, 2016-11-30 14:54:48]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2016-11-30 14:54:48]

The patchset sent to the CQ was uploaded after l-g-t-m from perkj@webrtc.org,
mflodman@webrtc.org, stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2496153002/#ps60001 (title:
"Remove left-over source files frame_preprocessor.*")

[commit-bot: I haz the power, 2016-11-30 14:54:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-30 15:01:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 15:01:43]

Try jobs failed on following builders:
  win_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_dbg/builds/13696)

[nisse-webrtc, 2016-11-30 15:13:20]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-11-30 15:13:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-30 15:30:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 15:30:54]

Try jobs failed on following builders:
  linux_msan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/15477)

[nisse-webrtc, 2016-11-30 15:41:23]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-11-30 15:41:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-30 15:44:52]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480520483012840,
"parent_rev": "76e8009a20d25e0adb221b432103758f41191dbb", "commit_rev":
"dfd59b93b0a96d808e205daa21ac95c8ba6b5f7e"}

[commit-bot: I haz the power, 2016-11-30 15:44:56]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-30 15:45:03]

Description was changed from

==========
Delete all of the video_processing module but the denoiser code.

It is unused since cl https://codereview.webrtc.org/2386573002.

The new denoiser implementation and its tests are kept for now. This
code is also unused, but there are some plans to take this code into
use in the not too distant future.

BUG=None
==========

to

==========
Delete all of the video_processing module but the denoiser code.

It is unused since cl https://codereview.webrtc.org/2386573002.

The new denoiser implementation and its tests are kept for now. This
code is also unused, but there are some plans to take this code into
use in the not too distant future.

BUG=None

Committed: https://crrev.com/13d38fbe904cd99acebf77068e93df34725eeb47
Cr-Commit-Position: refs/heads/master@{#15338}
==========

[commit-bot: I haz the power, 2016-11-30 15:45:04]

Patchset 4 (id:??) landed as
https://crrev.com/13d38fbe904cd99acebf77068e93df34725eeb47
Cr-Commit-Position: refs/heads/master@{#15338}