Chromium Code Reviews

Issue 2386573002: Releand of Let ViEEncoder handle resolution changes. (Closed)

Created:
4 years, 2 months ago by perkj_webrtc
Modified:
4 years, 2 months ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Releand of Let ViEEncoder handle resolution changes. The original landed cl is in patchset 1. The following patchset fix VideoQualityTest as well as fix the case where max_bitrate is set in the SendParams. A unit test is added for that as well. Original cl description: Let ViEEncoder handle resolution changes. This cl move codec reconfiguration due to video frame size changes from WebRtcVideoSendStream to ViEEncoder. With this change, many variables in WebRtcVideoSendStream no longer need to be locked. BUG=webrtc:5687, webrtc:6371, webrtc:5332 Committed: https://crrev.com/fa10b557d9051b421a39093ca83302f0fdf04705 Cr-Commit-Position: refs/heads/master@{#14467}

Patch Set 1 #

Patch Set 2 : Fix VideoQualityTest. #

Patch Set 3 : Add test for testing setting max_bitrate in SetSendParams. #

Patch Set 4 : Fix test VideoCapturerTest.ScreencastScaledOddWidth. #

Patch Set 5 : Rebased #

Unified diffs Side-by-side diffs Stats (+1177 lines, -670 lines)
M webrtc/api/videocapturertracksource_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments
M webrtc/call/bitrate_estimator_tests.cc View 2 chunks +3 lines, -4 lines 0 comments
M webrtc/call/call_perf_tests.cc View 7 chunks +41 lines, -11 lines 0 comments
M webrtc/call/rampup_tests.h View 1 chunk +1 line, -0 lines 0 comments
M webrtc/call/rampup_tests.cc View 2 chunks +31 lines, -7 lines 0 comments
M webrtc/config.h View 7 chunks +25 lines, -8 lines 0 comments
M webrtc/config.cc View 1 chunk +3 lines, -10 lines 0 comments
M webrtc/media/base/fakevideocapturer.h View 2 chunks +2 lines, -5 lines 0 comments
M webrtc/media/base/videocapturer_unittest.cc View 1 chunk +1 line, -1 line 0 comments
M webrtc/media/engine/constants.h View 1 chunk +1 line, -3 lines 0 comments
M webrtc/media/engine/fakewebrtccall.h View 2 chunks +2 lines, -1 line 0 comments
M webrtc/media/engine/fakewebrtccall.cc View 3 chunks +15 lines, -6 lines 0 comments
M webrtc/media/engine/webrtcvideoengine2.h View 2 chunks +25 lines, -45 lines 0 comments
M webrtc/media/engine/webrtcvideoengine2.cc View 24 chunks +237 lines, -247 lines 0 comments
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 12 chunks +68 lines, -47 lines 0 comments
M webrtc/test/call_test.h View 4 chunks +13 lines, -3 lines 0 comments
M webrtc/test/call_test.cc View 6 chunks +24 lines, -10 lines 0 comments
M webrtc/test/encoder_settings.h View 1 chunk +32 lines, -1 line 0 comments
M webrtc/test/encoder_settings.cc View 1 chunk +56 lines, -30 lines 0 comments
M webrtc/test/frame_generator.h View 1 chunk +5 lines, -0 lines 0 comments
M webrtc/test/frame_generator.cc View 3 chunks +17 lines, -9 lines 0 comments
M webrtc/test/frame_generator_capturer.h View 1 chunk +1 line, -0 lines 0 comments
M webrtc/test/frame_generator_capturer.cc View 1 chunk +5 lines, -0 lines 0 comments
M webrtc/video/end_to_end_tests.cc View 19 chunks +158 lines, -89 lines 0 comments
M webrtc/video/video_quality_test.cc View 2 chunks +27 lines, -1 line 0 comments
M webrtc/video/video_send_stream.cc View 2 chunks +4 lines, -14 lines 0 comments
M webrtc/video/video_send_stream_tests.cc View 28 chunks +234 lines, -51 lines 0 comments
M webrtc/video/vie_encoder.h View 4 chunks +21 lines, -1 line 0 comments
M webrtc/video/vie_encoder.cc View 10 chunks +67 lines, -42 lines 0 comments
M webrtc/video/vie_encoder_unittest.cc View 5 chunks +54 lines, -20 lines 0 comments
M webrtc/video_frame.h View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 21 (10 generated)
perkj_webrtc
please?
4 years, 2 months ago (2016-09-30 09:40:02 UTC) #3
mflodman
LG, but seems to still be some issue with the rtc unittest.
4 years, 2 months ago (2016-09-30 10:24:02 UTC) #4
perkj_webrtc
On 2016/09/30 10:24:02, mflodman wrote: > LG, but seems to still be some issue with ...
4 years, 2 months ago (2016-09-30 11:45:33 UTC) #5
mflodman
LGTM
4 years, 2 months ago (2016-09-30 13:16:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2386573002/60001
4 years, 2 months ago (2016-09-30 13:16:17 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 2 months ago (2016-09-30 13:45:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2386573002/60001
4 years, 2 months ago (2016-10-03 05:35:35 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/17261) linux_baremetal on master.tryserver.webrtc (JOB_FAILED, ...
4 years, 2 months ago (2016-10-03 05:37:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2386573002/80001
4 years, 2 months ago (2016-10-03 05:56:05 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 2 months ago (2016-10-03 06:45:30 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 06:45:39 UTC) #21
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/fa10b557d9051b421a39093ca83302f0fdf04705
Cr-Commit-Position: refs/heads/master@{#14467}

Powered by Google App Engine