Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2494403002: Revert of Temporarily remove ios_api_framework from the commit queue. (Closed)

Created:
4 years, 1 month ago by kjellander_webrtc
Modified:
4 years, 1 month ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Temporarily remove ios_api_framework from the commit queue. (patchset #2 id:40001 of https://codereview.webrtc.org/2341113004/ ) Reason for revert: The commit bot has been green for a while: https://build.chromium.org/p/client.webrtc/builders/iOS%20API%20Framework%20Builder/ Original issue's description: > Temporarily remove ios_api_framework from the commit queue. > > Temporarily remove ios_api_framework until [1] is ported to GN. > This script is blocking Chromium rolls > > [1]: https://cs.chromium.org/chromium/src/third_party/webrtc/build/ios/build_ios_libs.sh?sq=package:chromium&dr=C > > NOTRY=True > TBR=kjellander@webrtc.org > BUG=webrtc:6372 > > Committed: https://crrev.com/3d2ea1d2b363f2f65de0ca12d100040385db856b > Cr-Commit-Position: refs/heads/master@{#14266} TBR=ehmaldonado@webrtc.org NOTRY=True BUG=webrtc:6372 Committed: https://crrev.com/8c2ec19618b20e634bb75fe4417daf87ac632363 Cr-Commit-Position: refs/heads/master@{#15056}

Patch Set 1 #

Patch Set 2 : Manual rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M infra/config/cq.cfg View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
kjellander_webrtc
Created Revert of Temporarily remove ios_api_framework from the commit queue.
4 years, 1 month ago (2016-11-14 07:17:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2494403002/1
4 years, 1 month ago (2016-11-14 07:17:53 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/10129)
4 years, 1 month ago (2016-11-14 07:20:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2494403002/40001
4 years, 1 month ago (2016-11-14 07:30:23 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-11-14 07:31:48 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 07:32:01 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8c2ec19618b20e634bb75fe4417daf87ac632363
Cr-Commit-Position: refs/heads/master@{#15056}

Powered by Google App Engine
This is Rietveld 408576698