Add AudioOption for residual echo detector, and enable it by default on non-mobile platforms.

Add AudioOption for residual echo detector, and enable the echo detector by default on non-mobile platforms.

BUG=webrtc:6525
Committed: https://crrev.com/b829d9f2eefa9bbfdd10a4dd391b7d1bbfe4a733
Cr-Commit-Position: refs/heads/master@{#15079}

[ivoc, 2016-11-10 13:18:54]

Description was changed from

==========
Add mediaconstraint for residual echo detector, and enable it by default on
non-mobile platforms.

BUG=webrtc:6525
==========

to

==========
Add mediaconstraint for residual echo detector, and enable the echo detector by
default on non-mobile platforms.

BUG=webrtc:6525
==========

[ivoc, 2016-11-10 13:18:54]

ivoc@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org, solenberg@webrtc.org

[ivoc, 2016-11-10 13:21:16]

Hi guys, please have a look.

[the sun, 2016-11-10 14:00:17]

On 2016/11/10 13:21:16, ivoc wrote:
> Hi guys, please have a look.

The recommendation is to not use the constraints interface. See:
https://codereview.webrtc.org/2437803004/

[ivoc, 2016-11-10 14:46:43]

On 2016/11/10 14:00:17, the sun wrote:
> On 2016/11/10 13:21:16, ivoc wrote:
> > Hi guys, please have a look.
> 
> The recommendation is to not use the constraints interface. See:
> https://codereview.webrtc.org/2437803004/

Thanks for the heads up, I was not aware of that. I removed the mediaconstraint,
and just added it to cricket::AudioOptions like was suggested in that CL. PTAL.

[ivoc, 2016-11-10 14:55:32]

Description was changed from

==========
Add mediaconstraint for residual echo detector, and enable the echo detector by
default on non-mobile platforms.

BUG=webrtc:6525
==========

to

==========
Add AudioOption for residual echo detector, and enable the echo detector by
default on non-mobile platforms.

BUG=webrtc:6525
==========

[hlundin-webrtc, 2016-11-14 08:28:13]

lgtm

[the sun, 2016-11-14 18:18:49]

lgtm

[ivoc, 2016-11-15 10:07:56]

The CQ bit was checked by ivoc@webrtc.org

[commit-bot: I haz the power, 2016-11-15 10:08:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-15 10:34:49]

Description was changed from

==========
Add AudioOption for residual echo detector, and enable the echo detector by
default on non-mobile platforms.

BUG=webrtc:6525
==========

to

==========
Add AudioOption for residual echo detector, and enable the echo detector by
default on non-mobile platforms.

BUG=webrtc:6525
==========

[commit-bot: I haz the power, 2016-11-15 10:34:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-15 10:34:58]

Description was changed from

==========
Add AudioOption for residual echo detector, and enable the echo detector by
default on non-mobile platforms.

BUG=webrtc:6525
==========

to

==========
Add AudioOption for residual echo detector, and enable the echo detector by
default on non-mobile platforms.

BUG=webrtc:6525

Committed: https://crrev.com/b829d9f2eefa9bbfdd10a4dd391b7d1bbfe4a733
Cr-Commit-Position: refs/heads/master@{#15079}
==========

[commit-bot: I haz the power, 2016-11-15 10:34:59]

Patchset 2 (id:??) landed as
https://crrev.com/b829d9f2eefa9bbfdd10a4dd391b7d1bbfe4a733
Cr-Commit-Position: refs/heads/master@{#15079}