Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: webrtc/media/engine/webrtcvoiceengine.cc

Issue 2493753002: Add AudioOption for residual echo detector, and enable it by default on non-mobile platforms. (Closed)
Patch Set: Removed mediaconstraint. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/media/base/mediachannel.h ('k') | webrtc/modules/audio_processing/include/audio_processing.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/engine/webrtcvoiceengine.cc
diff --git a/webrtc/media/engine/webrtcvoiceengine.cc b/webrtc/media/engine/webrtcvoiceengine.cc
index a4768db49fc6d45c09c0b8ba994a26cec8d78a15..3b6ad87cc5cc56070fc2ec3498bfa7601265249a 100644
--- a/webrtc/media/engine/webrtcvoiceengine.cc
+++ b/webrtc/media/engine/webrtcvoiceengine.cc
@@ -606,6 +606,13 @@ WebRtcVoiceEngine::WebRtcVoiceEngine(
options.experimental_ns = rtc::Optional<bool>(false);
options.intelligibility_enhancer = rtc::Optional<bool>(false);
options.level_control = rtc::Optional<bool>(false);
+// TODO(ivoc): Always enable residual echo detector after benchmarking on
+// mobile.
+#if defined(WEBRTC_ANDROID) || defined(WEBRTC_IOS)
+ options.residual_echo_detector = rtc::Optional<bool>(false);
+#else
+ options.residual_echo_detector = rtc::Optional<bool>(true);
+#endif
bool error = ApplyOptions(options);
RTC_DCHECK(error);
}
@@ -670,6 +677,7 @@ bool WebRtcVoiceEngine::ApplyOptions(const AudioOptions& options_in) {
options.experimental_agc = rtc::Optional<bool>(false);
options.extended_filter_aec = rtc::Optional<bool>(false);
options.experimental_ns = rtc::Optional<bool>(false);
+ options.residual_echo_detector = rtc::Optional<bool>(false);
#endif
// Delay Agnostic AEC automatically turns on EC if not set except on iOS
« no previous file with comments | « webrtc/media/base/mediachannel.h ('k') | webrtc/modules/audio_processing/include/audio_processing.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698