Optimize FindCodecById and ReferencedCodecsMatch

Optimize FindCodecById and ReferencedCodecsMatch

These functions currently copy cricket::Codec classes by value which is
expensive since they contain e.g. std::map<std::string, std::string>
containers with parameters. This CL avoids copying them altogether.

BUG=webrtc:6337
Committed: https://crrev.com/b05fa2466a21ad0dfb4c750ebbb260675bce592f
Cr-Commit-Position: refs/heads/master@{#15040}

[magjed_webrtc, 2016-11-10 19:41:31]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 19:41:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[magjed_webrtc, 2016-11-10 19:44:33]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 19:44:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[magjed_webrtc, 2016-11-10 19:44:47]

Description was changed from

==========
Optimize FindCodecById and ReferencedCodecsMatch

These functions currently copy cricket::Codec classes by value which is
expensive since they contain e.g. std::map<std::string, std::string>
containers with parameters. This CL avoids copying them altogether.

BUG=None
==========

to

==========
Optimize FindCodecById and ReferencedCodecsMatch

These functions currently copy cricket::Codec classes by value which is
expensive since they contain e.g. std::map<std::string, std::string>
containers with parameters. This CL avoids copying them altogether.

BUG=None
==========

[magjed_webrtc, 2016-11-10 19:44:47]

magjed@webrtc.org changed reviewers:
+ tommi@webrtc.org

[commit-bot: I haz the power, 2016-11-10 20:22:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 20:22:54]

Dry run: This issue passed the CQ dry run.

[magjed_webrtc, 2016-11-10 21:29:38]

Patchset #1 (id:1) has been deleted

[magjed_webrtc, 2016-11-10 21:29:47]

Description was changed from

==========
Optimize FindCodecById and ReferencedCodecsMatch

These functions currently copy cricket::Codec classes by value which is
expensive since they contain e.g. std::map<std::string, std::string>
containers with parameters. This CL avoids copying them altogether.

BUG=None
==========

to

==========
Optimize FindCodecById and ReferencedCodecsMatch

These functions currently copy cricket::Codec classes by value which is
expensive since they contain e.g. std::map<std::string, std::string>
containers with parameters. This CL avoids copying them altogether.

BUG=webrtc:6337
==========

[magjed_webrtc, 2016-11-10 21:31:36]

tommi - please take a look.

[tommi, 2016-11-11 09:46:59]

lgtm

[magjed_webrtc, 2016-11-11 11:58:39]

The CQ bit was checked by magjed@webrtc.org

[commit-bot: I haz the power, 2016-11-11 11:58:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-11 12:00:18]

Description was changed from

==========
Optimize FindCodecById and ReferencedCodecsMatch

These functions currently copy cricket::Codec classes by value which is
expensive since they contain e.g. std::map<std::string, std::string>
containers with parameters. This CL avoids copying them altogether.

BUG=webrtc:6337
==========

to

==========
Optimize FindCodecById and ReferencedCodecsMatch

These functions currently copy cricket::Codec classes by value which is
expensive since they contain e.g. std::map<std::string, std::string>
containers with parameters. This CL avoids copying them altogether.

BUG=webrtc:6337
==========

[commit-bot: I haz the power, 2016-11-11 12:00:20]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-11-11 12:00:23]

Description was changed from

==========
Optimize FindCodecById and ReferencedCodecsMatch

These functions currently copy cricket::Codec classes by value which is
expensive since they contain e.g. std::map<std::string, std::string>
containers with parameters. This CL avoids copying them altogether.

BUG=webrtc:6337
==========

to

==========
Optimize FindCodecById and ReferencedCodecsMatch

These functions currently copy cricket::Codec classes by value which is
expensive since they contain e.g. std::map<std::string, std::string>
containers with parameters. This CL avoids copying them altogether.

BUG=webrtc:6337

Committed: https://crrev.com/b05fa2466a21ad0dfb4c750ebbb260675bce592f
Cr-Commit-Position: refs/heads/master@{#15040}
==========

[commit-bot: I haz the power, 2016-11-11 12:00:24]

Patchset 1 (id:??) landed as
https://crrev.com/b05fa2466a21ad0dfb4c750ebbb260675bce592f
Cr-Commit-Position: refs/heads/master@{#15040}