Optimize FindCodecById and ReferencedCodecsMatch

webrtc/media/base/codec.h

 /*
  *  Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 179 matching lines @@
   DataCodec(DataCodec&& c);
   virtual ~DataCodec() = default;
 
   DataCodec& operator=(const DataCodec& c);
   DataCodec& operator=(DataCodec&& c);
 
   std::string ToString() const;
 };
 
 // Get the codec setting associated with |payload_type|. If there
-// is no codec associated with that payload type it returns false.
+// is no codec associated with that payload type it returns nullptr.
 template <class Codec>
-bool FindCodecById(const std::vector<Codec>& codecs,
-                   int payload_type,
-                   Codec* codec_out) {
+const Codec* FindCodecById(const std::vector<Codec>& codecs, int payload_type) {
   for (const auto& codec : codecs) {
-    if (codec.id == payload_type) {
-      *codec_out = codec;
-      return true;
-    }
+    if (codec.id == payload_type)
+      return &codec;
   }
-  return false;
+  return nullptr;
 }
 
 bool CodecNamesEq(const std::string& name1, const std::string& name2);
 bool CodecNamesEq(const char* name1, const char* name2);
 webrtc::VideoCodecType CodecTypeFromName(const std::string& name);
 bool HasNack(const Codec& codec);
 bool HasRemb(const Codec& codec);
 bool HasTransportCc(const Codec& codec);
 bool IsCodecSupported(const std::vector<VideoCodec>& supported_codecs,
                       const VideoCodec& codec);
 
 }  // namespace cricket
 
 #endif  // WEBRTC_MEDIA_BASE_CODEC_H_