Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2493723002: Explicitly use RTX for RED in VideoQualityTest and video_loopback. (Closed)

Created:
4 years, 1 month ago by brandtr
Modified:
4 years, 1 month ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Explicitly use RTX for RED in VideoQualityTest and video_loopback. After the removal of the RED/RTX workaround, we now need to explicitly enable RTX for RED. Prior to the removal of the workaround, RED over RTX was implicitly enabled whenever media over RTX was enabled. BUG=webrtc:6650 Committed: https://crrev.com/8e75a523c8cecc71ba576c76e29b3ed8c039f8ed Cr-Commit-Position: refs/heads/master@{#15061}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M webrtc/video/video_quality_test.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
brandtr
This was the reason that the video_loopback performance was worse than the Chrome performance, after ...
4 years, 1 month ago (2016-11-10 08:24:49 UTC) #2
brandtr
Rebase
4 years, 1 month ago (2016-11-10 09:04:46 UTC) #3
stefan-webrtc
lgtm
4 years, 1 month ago (2016-11-14 10:32:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2493723002/20001
4 years, 1 month ago (2016-11-14 11:29:55 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-14 12:07:26 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 12:07:35 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8e75a523c8cecc71ba576c76e29b3ed8c039f8ed
Cr-Commit-Position: refs/heads/master@{#15061}

Powered by Google App Engine
This is Rietveld 408576698