Stop using hardcoded payload types for video codecs

webrtc/api/webrtcsdp_unittest.cc

Index: webrtc/api/webrtcsdp_unittest.cc
diff --git a/webrtc/api/webrtcsdp_unittest.cc b/webrtc/api/webrtcsdp_unittest.cc
index 3c6643f2aac384dd2ac623b2a3ee7eef61abd9f9..7941323d973d264cad8b4c92adb573c129e94e4b 100644
--- a/webrtc/api/webrtcsdp_unittest.cc
+++ b/webrtc/api/webrtcsdp_unittest.cc
@@ -2083,11 +2083,12 @@ TEST_F(WebRtcSdpTest, SerializeTcpCandidates) {
 }
 
 TEST_F(WebRtcSdpTest, SerializeSessionDescriptionWithH264) {
-  if (!webrtc::H264Encoder::IsSupported())
-    return;
-  for (const auto& codec : cricket::DefaultVideoCodecList()) {
-    video_desc_->AddCodec(codec);
-  }
+  cricket::VideoCodec h264_codec("H264");

[hta-webrtc, 2016/11/15 11:34:59]

Does this compile & run if you're compiling without H.264 support?

[magjed_webrtc, 2016/11/15 17:18:26]

Yes, it doesn't use the actual encoder, it just serializes the
cricket::VideoCodec.

+  h264_codec.SetParam("profile-level-id", "42e01f");

[hta-webrtc, 2016/11/15 11:34:59]

Can you use the constructor and stringifier for profile-level-id, so that it's
easier to see what you're testing?

[magjed_webrtc, 2016/11/15 17:18:26]

I can, but in the test we are checking:
EXPECT_NE(std::string::npos, fmtp_value.find("profile-level-id=42e01f"));
so maybe it's clearer to use the same string here?

[hta-webrtc, 2016/11/15 20:36:24]

Acknowledged.

+  h264_codec.SetParam("level-asymmetry-allowed", "1");
+  h264_codec.SetParam("packetization-mode", "1");
+  video_desc_->AddCodec(h264_codec);

[stefan-webrtc, 2016/11/15 09:00:08]

Could you explain why this change is needed? Do I have to review code in
webrtc/media to understand it?

[magjed_webrtc, 2016/11/15 17:18:26]

This change is needed because cricket::DefaultVideoCodecList() does not exist
anymore. Also, I don't think this unittest should have any dependency to a real
codec implementation. We should only be testing serialization of session
description with H264. So basically, the old 'cricket::DefaultVideoCodecList()'
is faked here with only the H264 codec.

+
   jdesc_.Initialize(desc_.Copy(), kSessionId, kSessionVersion);
 
   std::string message = webrtc::SdpSerialize(jdesc_, false);