Stop using hardcoded payload types for video codecs

webrtc/media/engine/payload_type_mapper_unittest.cc

Index: webrtc/media/engine/payload_type_mapper_unittest.cc
diff --git a/webrtc/media/engine/payload_type_mapper_unittest.cc b/webrtc/media/engine/payload_type_mapper_unittest.cc
index 8e00dbc2b708c8b3435e29f9cd607450017929ed..dd562e191815796f4fdcaa5a6b83c8b0cda2d4e5 100644
--- a/webrtc/media/engine/payload_type_mapper_unittest.cc
+++ b/webrtc/media/engine/payload_type_mapper_unittest.cc
@@ -62,25 +62,6 @@ TEST_F(PayloadTypeMapperTest, StaticPayloadTypes) {
 TEST_F(PayloadTypeMapperTest, WebRTCPayloadTypes) {
   // Tests that the payload mapper knows about the formats we've been using in
   // WebRTC, with their hard coded values.

[hta-webrtc, 2016/11/15 11:34:59]

Shouldn't there be a test that runs thorugh the codec names and checks that
they're present, non-zero and distinct?

[magjed_webrtc, 2016/11/15 17:18:26]

Do you mean instead of the existing test below that checks what the actual
payload types are for the audio codecs? Probably, but I didn't want to touch
more code than necessary. This class is only used for audio codecs so the codec
names for e.g. VP8, VP9, etc are not mapped by this class at all so I just
removed all references to the video codecs here.

[hta-webrtc, 2016/11/15 20:36:24]

That makes sense. Can you add the word "audio" to the comment above so that it's
obvious?

"...knows about the audio formats we've been using in WebRTC ..."

[magjed_webrtc, 2016/11/16 13:44:10]

Done.

-  auto video_mapping = [this] (const char *name) {
-    return FindMapping({name, kVideoCodecClockrate, 0});
-  };
-  EXPECT_EQ(kDefaultVp8PlType,  video_mapping(kVp8CodecName));
-  EXPECT_EQ(kDefaultVp9PlType,  video_mapping(kVp9CodecName));
-  EXPECT_EQ(kDefaultH264PlType, video_mapping(kH264CodecName));
-  EXPECT_EQ(kDefaultRedPlType,  video_mapping(kRedCodecName));
-  EXPECT_EQ(kDefaultUlpfecType, video_mapping(kUlpfecCodecName));
-  EXPECT_EQ(kDefaultFlexfecPlType, video_mapping(kFlexfecCodecName));
-
-  auto rtx_mapping = [this] (int payload_type) {
-    return FindMapping({kRtxCodecName, kVideoCodecClockrate, 0,
-        {{ kCodecParamAssociatedPayloadType, std::to_string(payload_type)}}});
-  };
-  EXPECT_EQ(kDefaultRtxVp8PlType,  rtx_mapping(kDefaultVp8PlType));
-  EXPECT_EQ(kDefaultRtxVp9PlType,  rtx_mapping(kDefaultVp9PlType));
-  EXPECT_EQ(kDefaultRtxH264PlType, rtx_mapping(kDefaultH264PlType));
-  EXPECT_EQ(kDefaultRtxRedPlType,  rtx_mapping(kDefaultRedPlType));
-
   EXPECT_EQ(102, FindMapping({kIlbcCodecName,  8000, 1}));
   EXPECT_EQ(103, FindMapping({kIsacCodecName, 16000, 1}));
   EXPECT_EQ(104, FindMapping({kIsacCodecName, 32000, 1}));