Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2489523003: Remove GetPreferredTryMasters from PRESUBMIT. (Closed)

Created:
4 years, 1 month ago by kjellander_webrtc
Modified:
4 years, 1 month ago
Reviewers:
tandrii(chromium)
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove GetPreferredTryMasters from PRESUBMIT. git cl try will then trigger CQ dry run, achieving even better result, because PRESUBMIT will be run as well. TBR=tandrii@chromium.org BUG=663320 NOTRY=True Committed: https://crrev.com/56827ef5276b5bbb363bff98f64056e048533d22 Cr-Commit-Position: refs/heads/master@{#14976}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -28 lines) Patch
M PRESUBMIT.py View 2 chunks +0 lines, -28 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kjellander_webrtc
4 years, 1 month ago (2016-11-08 13:53:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2489523003/1
4 years, 1 month ago (2016-11-08 13:53:30 UTC) #5
tandrii(chromium)
lgtm
4 years, 1 month ago (2016-11-08 13:54:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 13:55:45 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 13:55:57 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56827ef5276b5bbb363bff98f64056e048533d22
Cr-Commit-Position: refs/heads/master@{#14976}

Powered by Google App Engine
This is Rietveld 408576698