Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: PRESUBMIT.py

Issue 2489523003: Remove GetPreferredTryMasters from PRESUBMIT. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index da193b4867c4afdfdec0465e440b8be0e09f68c5..1f3f3f5d6e93800b9bcdc99e8450603c21baab6d 100755
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -6,11 +6,8 @@
# in the file PATENTS. All contributing project authors may
# be found in the AUTHORS file in the root of the source tree.
-import json
import os
-import platform
import re
-import subprocess
import sys
@@ -619,28 +616,3 @@ def CheckChangeOnCommit(input_api, output_api):
input_api, output_api,
json_url='http://webrtc-status.appspot.com/current?format=json'))
return results
-
-
-# pylint: disable=W0613
-def GetPreferredTryMasters(project, change):
- cq_config_path = os.path.join(
- change.RepositoryRoot(), 'infra', 'config', 'cq.cfg')
- # commit_queue.py below is a script in depot_tools directory, which has a
- # 'builders' command to retrieve a list of CQ builders from the CQ config.
- is_win = platform.system() == 'Windows'
- masters = json.loads(subprocess.check_output(
- ['commit_queue', 'builders', cq_config_path], shell=is_win))
-
- try_config = {}
- for master in masters:
- try_config.setdefault(master, {})
- for builder in masters[master]:
- if 'presubmit' in builder:
- # Do not trigger presubmit builders, since they're likely to fail
- # (e.g. OWNERS checks before finished code review), and we're running
- # local presubmit anyway.
- pass
- else:
- try_config[master][builder] = ['defaulttests']
-
- return try_config
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698