Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2489343002: Corrected the way that the settings for the new APM parameter scheme are applied in VoiceEngine (Closed)

Created:
4 years, 1 month ago by peah-webrtc
Modified:
4 years, 1 month ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

In VoiceEngine, the settings for APM are applied in such a way that the previously specified setting is changed if it is specified to be changed, and otherwise the previously specified setting is kept as it is. This CL replicates this functionality for the way that the new APM parameter scheme is used. BUG=webrtc::6220, webrtc::6296, webrtc::6297, webrtc::6181, webrtc::5298 Committed: https://crrev.com/64d6ff77ffa326cb6132706f7ed3879081b0b92f Cr-Commit-Position: refs/heads/master@{#15167}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M webrtc/media/engine/webrtcvoiceengine.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
peah-webrtc
4 years, 1 month ago (2016-11-10 15:19:25 UTC) #3
the sun
lgtm
4 years, 1 month ago (2016-11-21 10:03:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2489343002/20001
4 years, 1 month ago (2016-11-21 14:04:49 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-21 14:28:18 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 14:28:26 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/64d6ff77ffa326cb6132706f7ed3879081b0b92f
Cr-Commit-Position: refs/heads/master@{#15167}

Powered by Google App Engine
This is Rietveld 408576698