Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: webrtc/media/engine/webrtcvoiceengine.h

Issue 2489343002: Corrected the way that the settings for the new APM parameter scheme are applied in VoiceEngine (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/media/engine/webrtcvoiceengine.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 10 matching lines...) Expand all
21 #include "webrtc/base/constructormagic.h" 21 #include "webrtc/base/constructormagic.h"
22 #include "webrtc/base/networkroute.h" 22 #include "webrtc/base/networkroute.h"
23 #include "webrtc/base/scoped_ref_ptr.h" 23 #include "webrtc/base/scoped_ref_ptr.h"
24 #include "webrtc/base/stream.h" 24 #include "webrtc/base/stream.h"
25 #include "webrtc/base/thread_checker.h" 25 #include "webrtc/base/thread_checker.h"
26 #include "webrtc/call.h" 26 #include "webrtc/call.h"
27 #include "webrtc/config.h" 27 #include "webrtc/config.h"
28 #include "webrtc/media/base/rtputils.h" 28 #include "webrtc/media/base/rtputils.h"
29 #include "webrtc/media/engine/webrtccommon.h" 29 #include "webrtc/media/engine/webrtccommon.h"
30 #include "webrtc/media/engine/webrtcvoe.h" 30 #include "webrtc/media/engine/webrtcvoe.h"
31 #include "webrtc/modules/audio_processing/include/audio_processing.h"
31 #include "webrtc/pc/channel.h" 32 #include "webrtc/pc/channel.h"
32 33
33 namespace cricket { 34 namespace cricket {
34 35
35 class AudioDeviceModule; 36 class AudioDeviceModule;
36 class AudioSource; 37 class AudioSource;
37 class VoEWrapper; 38 class VoEWrapper;
38 class WebRtcVoiceMediaChannel; 39 class WebRtcVoiceMediaChannel;
39 40
40 // WebRtcVoiceEngine is a class to be used with CompositeMediaEngine. 41 // WebRtcVoiceEngine is a class to be used with CompositeMediaEngine.
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 // level controller, and intelligibility_enhancer values, and apply them 128 // level controller, and intelligibility_enhancer values, and apply them
128 // in case they are missing in the audio options. We need to do this because 129 // in case they are missing in the audio options. We need to do this because
129 // SetExtraOptions() will revert to defaults for options which are not 130 // SetExtraOptions() will revert to defaults for options which are not
130 // provided. 131 // provided.
131 rtc::Optional<bool> extended_filter_aec_; 132 rtc::Optional<bool> extended_filter_aec_;
132 rtc::Optional<bool> delay_agnostic_aec_; 133 rtc::Optional<bool> delay_agnostic_aec_;
133 rtc::Optional<bool> experimental_ns_; 134 rtc::Optional<bool> experimental_ns_;
134 rtc::Optional<bool> intelligibility_enhancer_; 135 rtc::Optional<bool> intelligibility_enhancer_;
135 rtc::Optional<bool> level_control_; 136 rtc::Optional<bool> level_control_;
136 137
138 webrtc::AudioProcessing::Config apm_config_;
139
137 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(WebRtcVoiceEngine); 140 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(WebRtcVoiceEngine);
138 }; 141 };
139 142
140 // WebRtcVoiceMediaChannel is an implementation of VoiceMediaChannel that uses 143 // WebRtcVoiceMediaChannel is an implementation of VoiceMediaChannel that uses
141 // WebRtc Voice Engine. 144 // WebRtc Voice Engine.
142 class WebRtcVoiceMediaChannel final : public VoiceMediaChannel, 145 class WebRtcVoiceMediaChannel final : public VoiceMediaChannel,
143 public webrtc::Transport { 146 public webrtc::Transport {
144 public: 147 public:
145 WebRtcVoiceMediaChannel(WebRtcVoiceEngine* engine, 148 WebRtcVoiceMediaChannel(WebRtcVoiceEngine* engine,
146 const MediaConfig& config, 149 const MediaConfig& config,
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
272 std::map<uint32_t, WebRtcAudioReceiveStream*> recv_streams_; 275 std::map<uint32_t, WebRtcAudioReceiveStream*> recv_streams_;
273 std::vector<webrtc::RtpExtension> recv_rtp_extensions_; 276 std::vector<webrtc::RtpExtension> recv_rtp_extensions_;
274 277
275 webrtc::AudioSendStream::Config::SendCodecSpec send_codec_spec_; 278 webrtc::AudioSendStream::Config::SendCodecSpec send_codec_spec_;
276 279
277 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(WebRtcVoiceMediaChannel); 280 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(WebRtcVoiceMediaChannel);
278 }; 281 };
279 } // namespace cricket 282 } // namespace cricket
280 283
281 #endif // WEBRTC_MEDIA_ENGINE_WEBRTCVOICEENGINE_H_ 284 #endif // WEBRTC_MEDIA_ENGINE_WEBRTCVOICEENGINE_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/media/engine/webrtcvoiceengine.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698