Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 2484913003: Revert of Add a webrtc{en,de}coderfactory implementation for VideoToolbox (Closed)

Created:
4 years, 1 month ago by kwiberg-webrtc
Modified:
4 years, 1 month ago
Reviewers:
magjed_webrtc, kthelgason, holmer, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add a webrtc{en,de}coderfactory implementation for VideoToolbox (patchset #2 id:20001 of https://codereview.webrtc.org/2463313002/ ) Reason for revert: Broke dependent project because the .gn changes weren't accompanied by corresponding .gyp changes. Original issue's description: > Add a webrtc{en,de}coderfactory implementation for VideoToolbox > > This CL removes the coupling of the VideoToolbox h264 implementation > to the generic h264 code. The files have been moved into sdb/obj/Framework > and all dependency on them has been removed from the rest of WebRTC. > We now add it as an external encoder via a factory supplied to the > CreatePeerConnectionFactory call. This also brings the iOS implementation > closer to what we do on Android for MediaCodec. > > BUG=webrtc:6619 > > Committed: https://crrev.com/6a5047dad31f14f53dd9f8bc1ecde19e1dede2e4 > Cr-Commit-Position: refs/heads/master@{#14953} TBR=magjed@webrtc.org,holmer@webrtc.org,stefan@webrtc.org,kthelgason@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6619

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1980 lines, -2007 lines) Patch
M webrtc/modules/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 2 chunks +59 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264.cc View 4 chunks +28 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264.gypi View 2 chunks +45 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/codecs/h264/h264_objc.mm View 1 chunk +32 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_decoder.h View 1 chunk +62 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_decoder.cc View 1 chunk +281 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.h View 1 chunk +98 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.mm View 1 chunk +663 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_nalu.h View 1 chunk +111 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_nalu.cc View 1 chunk +397 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_nalu_unittest.cc View 1 chunk +195 lines, -0 lines 0 comments Download
M webrtc/sdk/BUILD.gn View 6 chunks +4 lines, -61 lines 0 comments Download
M webrtc/sdk/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm View 2 chunks +1 line, -8 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_decoder.h View 1 chunk +0 lines, -59 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_decoder.cc View 1 chunk +0 lines, -277 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h View 1 chunk +0 lines, -95 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm View 1 chunk +0 lines, -659 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_nalu.h View 1 chunk +0 lines, -108 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_nalu.cc View 1 chunk +0 lines, -393 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_nalu_unittest.cc View 1 chunk +0 lines, -191 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/videotoolboxvideocodecfactory.h View 1 chunk +0 lines, -50 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/videotoolboxvideocodecfactory.cc View 1 chunk +0 lines, -103 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kwiberg-webrtc
Created Revert of Add a webrtc{en,de}coderfactory implementation for VideoToolbox
4 years, 1 month ago (2016-11-08 16:49:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2484913003/1
4 years, 1 month ago (2016-11-08 16:49:46 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios32_sim_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/12297) ios64_sim_dbg on master.tryserver.webrtc (JOB_FAILED, ...
4 years, 1 month ago (2016-11-08 16:51:35 UTC) #5
kwiberg-webrtc
4 years, 1 month ago (2016-11-08 18:46:04 UTC) #6
Landed a manually created revert instead
(https://codereview.webrtc.org/2483273002/), since this one didn't build
correctly. Seems like Rietveld's revert button failed to create a proper revert,
but I didn't take the time to compare the two diffs in any sort of detail.

Powered by Google App Engine
This is Rietveld 408576698