Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2484863007: Revert of Simplify and extend RtpHeaderExtensionMap (Closed)

Created:
4 years, 1 month ago by danilchap
Modified:
4 years, 1 month ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman, brandtr
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Simplify and extend RtpHeaderExtensionMap (patchset #12 id:260001 of https://codereview.webrtc.org/2452293004/ ) Reason for revert: breaks downstream project Original issue's description: > Simplify and extend RtpHeaderExtensionMap > Add register functions for various codepaths. > Add initialize-list constructor to create usable const RtpHeaderExtensionMap > Optimize implementation for GetId/GetType. > > BUG=webrtc:1994 > > Committed: https://crrev.com/d1d26fbeb37a69471a34004c6ac2d3fafde5d404 > Cr-Commit-Position: refs/heads/master@{#14986} TBR=sprang@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:1994 Committed: https://crrev.com/bc38b4d450a80bf45efbe5b0a452e0374cdae1e6 Cr-Commit-Position: refs/heads/master@{#14988}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -247 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_header_extension.h View 2 chunks +57 lines, -49 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_extension.cc View 1 chunk +117 lines, -112 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_extension_unittest.cc View 1 chunk +57 lines, -69 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_extensions.h View 6 chunks +7 lines, -11 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc View 6 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
danilchap
Created Revert of Simplify and extend RtpHeaderExtensionMap
4 years, 1 month ago (2016-11-08 21:36:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2484863007/1
4 years, 1 month ago (2016-11-08 21:36:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 21:36:40 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bc38b4d450a80bf45efbe5b0a452e0374cdae1e6 Cr-Commit-Position: refs/heads/master@{#14988}
4 years, 1 month ago (2016-11-08 21:36:54 UTC) #6
danilchap
4 years, 1 month ago (2016-11-09 12:47:46 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2492443002/ by danilchap@webrtc.org.

The reason for reverting is: dependent project adjusted.

Powered by Google App Engine
This is Rietveld 408576698