Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2470663004:
Synchronous adb shell and pull for loopback start script (Closed)
DescriptionSynchronous adb shell and pull for loopback start script
Before the removal and copy of script of video file on the android
device was done asynchronously, which was a bug.
BUG=webrtc:6545
NOTRY=True
Committed: https://crrev.com/3e79dbdc377807972a15bd9172ed4d25e7a27d55
Cr-Commit-Position: refs/heads/master@{#14898}
Patch Set 1 #
Messages
Total messages: 28 (14 generated)
mandermo@webrtc.org changed reviewers: + kjellander_webrtc@webrtc.org, phoglund@webrtc.org
Asychronous adb pull for loopback start script Before the removal and copy of script of video file on the android device was done asychrounously, which was a bug.
mandermo@webrtc.org changed reviewers: + kjellander@webrtc.org - kjellander_webrtc@webrtc.org
Did error adding reviewer.
Description was changed from ========== Asychronous adb pull for loopback start script Before the removal and copy of script of video file on the android device was done asychrounously, which was a bug. BUG=webrtc:6545 ========== to ========== Synchronous adb shall and pull for loopback start script Before the removal and copy of script of video file on the android device was done asynchronously, which was a bug. BUG=webrtc:6545 ==========
Description was changed from ========== Synchronous adb shall and pull for loopback start script Before the removal and copy of script of video file on the android device was done asynchronously, which was a bug. BUG=webrtc:6545 ========== to ========== Synchronous adb shall and pull for loopback start script Before the removal and copy of script of video file on the android device was done asynchronously, which was a bug. BUG=webrtc:6545 NOTRY=True ==========
I changed the CL title to "Synchronous adb shall and pull for loopback start script". That's what you meant, right? I also fixed a spelling error in the description and added NOTRY=True since it doesn't make sense to run trybots on this change. LGTM
lgtm
kjellander_webrtc@ yes, asychrounous should be changed to Synchronous. I also fixed so removal of old file is synchronous, but maybe we don't need to mention that. What do you mean with "adb shall", so title maybe be "Synchronous adb pull for loopback start script"?
Description was changed from ========== Synchronous adb shall and pull for loopback start script Before the removal and copy of script of video file on the android device was done asynchronously, which was a bug. BUG=webrtc:6545 NOTRY=True ========== to ========== Synchronous adb shell and pull for loopback start script Before the removal and copy of script of video file on the android device was done asynchronously, which was a bug. BUG=webrtc:6545 NOTRY=True ==========
On 2016/11/02 13:07:44, mandermo wrote: > kjellander_webrtc@ yes, asychrounous should be changed to Synchronous. I also > fixed so removal of old file is synchronous, but maybe we don't need to mention > that. What do you mean with "adb shall", so title maybe be "Synchronous adb pull > for loopback start script"? I meant 'adb shell' as one of the adb commands was that. I updated it again.
The CQ bit was checked by mandermo@webrtc.org
The CQ bit was unchecked by mandermo@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by mandermo@webrtc.org
The CQ bit was checked by mandermo@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9748)
mandermo@webrtc.org changed reviewers: + magjed@webrtc.org
+magjed because of OWNERS.
lgtm
The CQ bit was checked by mandermo@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Synchronous adb shell and pull for loopback start script Before the removal and copy of script of video file on the android device was done asynchronously, which was a bug. BUG=webrtc:6545 NOTRY=True ========== to ========== Synchronous adb shell and pull for loopback start script Before the removal and copy of script of video file on the android device was done asynchronously, which was a bug. BUG=webrtc:6545 NOTRY=True ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Synchronous adb shell and pull for loopback start script Before the removal and copy of script of video file on the android device was done asynchronously, which was a bug. BUG=webrtc:6545 NOTRY=True ========== to ========== Synchronous adb shell and pull for loopback start script Before the removal and copy of script of video file on the android device was done asynchronously, which was a bug. BUG=webrtc:6545 NOTRY=True Committed: https://crrev.com/3e79dbdc377807972a15bd9172ed4d25e7a27d55 Cr-Commit-Position: refs/heads/master@{#14898} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3e79dbdc377807972a15bd9172ed4d25e7a27d55 Cr-Commit-Position: refs/heads/master@{#14898} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
