webrtc/examples/androidapp/start_loopback_stubbed_camera_saved_video_out.py - Issue 2470663004: Synchronous adb shell and pull for loopback start script

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/examples/androidapp/start_loopback_stubbed_camera_saved_video_out.py

Issue 2470663004: Synchronous adb shell and pull for loopback start script (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/examples/androidapp/start_loopback_stubbed_camera_saved_video_out.py

diff --git a/webrtc/examples/androidapp/start_loopback_stubbed_camera_saved_video_out.py b/webrtc/examples/androidapp/start_loopback_stubbed_camera_saved_video_out.py

index a2664615905d90a43c862f38dbea5b118fa0b17d..b3a9e2ee9deee1fb3fb2b535c2d82665a5381e80 100644

--- a/webrtc/examples/androidapp/start_loopback_stubbed_camera_saved_video_out.py

+++ b/webrtc/examples/androidapp/start_loopback_stubbed_camera_saved_video_out.py

@@ -74,7 +74,7 @@ def main():

# Delete output video file.

if videoout:

- subprocess.Popen(['adb', '-s', devname, 'shell', 'rm',

+ subprocess.check_call(['adb', '-s', devname, 'shell', 'rm',

videoout])

device = MonkeyRunner.waitForConnection(2, devname)

@@ -116,7 +116,7 @@ def main():

if videooutsave:

time.sleep(2)

- subprocess.Popen(['adb', '-s', devname, 'pull',

+ subprocess.check_call(['adb', '-s', devname, 'pull',

videoout, videooutsave])

if __name__ == '__main__':

« no previous file with comments | « no previous file | no next file » | no next file with comments »