Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_sender.cc

Issue 2469093003: Remove RED/RTX workaround from sender/receiver and VideoEngine2. (Closed)
Patch Set: Fix warning message. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc ('k') | webrtc/video/rtp_stream_receiver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/source/rtp_sender.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_sender.cc b/webrtc/modules/rtp_rtcp/source/rtp_sender.cc
index 36915c53afeb7fdf9c3a18bf7de53ce4d7f67f84..0a244d13e9bd12f0faa6366786b542f2f89d9870 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_sender.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtp_sender.cc
@@ -1158,16 +1158,12 @@ std::unique_ptr<RtpPacketToSend> RTPSender::BuildRtxPacket(
rtc::CritScope lock(&send_critsect_);
if (!sending_media_)
return nullptr;
- // Replace payload type, if a specific type is set for RTX.
- auto kv = rtx_payload_type_map_.find(packet.PayloadType());
- // Use rtx mapping associated with media codec if we can't find one,
- // assume it's red.
- // TODO(holmer): Remove once old Chrome versions don't rely on this.
+ // Replace payload type.
+ auto kv = rtx_payload_type_map_.find(packet.PayloadType());
if (kv == rtx_payload_type_map_.end())
- kv = rtx_payload_type_map_.find(payload_type_);
- if (kv != rtx_payload_type_map_.end())
- rtx_packet->SetPayloadType(kv->second);
+ return nullptr;
+ rtx_packet->SetPayloadType(kv->second);
// Replace sequence number.
rtx_packet->SetSequenceNumber(sequence_number_rtx_++);
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc ('k') | webrtc/video/rtp_stream_receiver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698