Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc

Issue 2469093003: Remove RED/RTX workaround from sender/receiver and VideoEngine2. (Closed)
Patch Set: Fix warning message. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc
index fa2b3a811e666a849c5f5f7c46236dd551a1cab3..abb2ae91c4eedbbfca564949ac6f2ee5bcab946b 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc
@@ -350,26 +350,6 @@ TEST_F(RtpPayloadRegistryTest, InvalidRtxConfiguration) {
TestRtxPacket(rtp_payload_registry_.get(), 106, 0, false);
}
-TEST_F(RtpPayloadRegistryTest, AssumeRtxWrappingRed) {
- rtp_payload_registry_->SetRtxSsrc(100);
- // Succeeds when the mapping is used, but fails for the implicit fallback.
- rtp_payload_registry_->SetRtxPayloadType(105, 95);
- // Set the incoming payload type to 96, which we assume is red.
- RTPHeader header;
- header.payloadType = 96;
- header.ssrc = 1;
- rtp_payload_registry_->SetIncomingPayloadType(header);
- // Recovers with correct, but unexpected, payload type since we haven't
- // configured red.
- TestRtxPacket(rtp_payload_registry_.get(), 105, 95, true);
- bool created_new_payload;
- rtp_payload_registry_->RegisterReceivePayload(
- "RED", header.payloadType, 90000, 1, 0, &created_new_payload);
- // Now that red is configured we expect to get the red payload type back on
- // recovery because of the workaround to always recover red when configured.
- TestRtxPacket(rtp_payload_registry_.get(), 105, header.payloadType, true);
-}
-
INSTANTIATE_TEST_CASE_P(TestDynamicRange,
RtpPayloadRegistryGenericTest,
testing::Range(96, 127 + 1));
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc ('k') | webrtc/modules/rtp_rtcp/source/rtp_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698