RtpFrameObject::GetCodecHeader now return rtc::Optional<RTPVideoTypeHeader>

webrtc/modules/video_coding/frame_object.h

Index: webrtc/modules/video_coding/frame_object.h
diff --git a/webrtc/modules/video_coding/frame_object.h b/webrtc/modules/video_coding/frame_object.h
index 542797226e99434dc6e6e95b5c81599ddc47ef48..915224ede8de70bdd45ec7c27962e8d8a58ae4e1 100644
--- a/webrtc/modules/video_coding/frame_object.h
+++ b/webrtc/modules/video_coding/frame_object.h
@@ -11,6 +11,7 @@
 #ifndef WEBRTC_MODULES_VIDEO_CODING_FRAME_OBJECT_H_
 #define WEBRTC_MODULES_VIDEO_CODING_FRAME_OBJECT_H_
 
+#include "webrtc/base/optional.h"
 #include "webrtc/common_types.h"
 #include "webrtc/modules/include/module_common_types.h"
 #include "webrtc/modules/video_coding/encoded_frame.h"
@@ -71,7 +72,7 @@ class RtpFrameObject : public FrameObject {
   uint32_t Timestamp() const override;
   int64_t ReceivedTime() const override;
   int64_t RenderTime() const override;
-  RTPVideoTypeHeader* GetCodecHeader() const;
+  rtc::Optional<RTPVideoTypeHeader> GetCodecHeader() const;

[terelius, 2016/11/02 13:08:18]

How large is the RTPVideoTypeHeader, and how often is the function called?
(I.e., will this have any performance impact?)

[philipel, 2016/11/02 13:12:24]

It is 1624 bytes, and it is called ~1 time per frame (can be more if the frame
is retried in the RtpFrameReferenceFinder)

[terelius, 2016/11/02 13:18:38]

A 1.5 kB header seems like a lot. Does it have to be that large? Do you need the
entire header, or would it be possible to just copy parts of it as a future
optimization?

[philipel, 2016/11/02 13:26:14]

It is quite large (in fact it is larger than the bitstream data that we want to
avoid copying) due to the GofInfoVP9 which contains multiple arrays and a matrix
that is mostly unused. Maybe the Gof can be stored more efficiently.

[terelius, 2016/11/02 13:34:49]

Ok. Can you file a feature request in the bugtracker for a more compact
representation of the Gof? A sparse representation of the matrix might be
useful.

 
  private:
   rtc::scoped_refptr<PacketBuffer> packet_buffer_;