Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: webrtc/modules/video_coding/frame_object.cc

Issue 2468183002: RtpFrameObject::GetCodecHeader now return rtc::Optional<RTPVideoTypeHeader> (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/frame_object.cc
diff --git a/webrtc/modules/video_coding/frame_object.cc b/webrtc/modules/video_coding/frame_object.cc
index acfb25d28d3594e4a0d2047091f20c2238ff8a3a..b8031796d972d3cab7db979a1969344b2b5edf80 100644
--- a/webrtc/modules/video_coding/frame_object.cc
+++ b/webrtc/modules/video_coding/frame_object.cc
@@ -9,7 +9,6 @@
*/
#include "webrtc/modules/video_coding/frame_object.h"
-#include "webrtc/base/criticalsection.h"
#include "webrtc/modules/video_coding/packet_buffer.h"
namespace webrtc {
@@ -97,11 +96,12 @@ int64_t RtpFrameObject::RenderTime() const {
return _renderTimeMs;
}
-RTPVideoTypeHeader* RtpFrameObject::GetCodecHeader() const {
+rtc::Optional<RTPVideoTypeHeader> RtpFrameObject::GetCodecHeader() const {
+ rtc::CritScope lock(&packet_buffer_->crit_);
VCMPacket* packet = packet_buffer_->GetPacket(first_seq_num_);
if (!packet)
- return nullptr;
- return &packet->video_header.codecHeader;
+ return rtc::Optional<RTPVideoTypeHeader>();
+ return rtc::Optional<RTPVideoTypeHeader>(packet->video_header.codecHeader);
}
} // namespace video_coding

Powered by Google App Engine
This is Rietveld 408576698