Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2465223002: Revert of RTCOutboundRTPStreamStats added. (Closed)

Created:
4 years, 1 month ago by perkj_webrtc
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of RTCOutboundRTPStreamStats added. (patchset #3 id:80001 of https://codereview.webrtc.org/2456463002/ ) Reason for revert: Breaks Chrome FYI. peerconnection_unittest calls RTCStatsReport::Create without parameters. Original issue's description: > RTCOutboundRTPStreamStats[1] added. > > This also adds RTCRTPStreamStats[2] which it derives from. Not all stats > are supported in this CL, this must be addressed before closing the > issue. > > RTCStatsReport also gets a timestamp and ToString. > > [1] https://w3c.github.io/webrtc-stats/#outboundrtpstats-dict* > [2] https://w3c.github.io/webrtc-stats/#streamstats-dict* > > BUG=chromium:627816, chromium:657856, chromium:657854 > > Committed: https://crrev.com/69e9cb08285f6cbcab547c7a5e6aa668fa6f2d29 > Cr-Commit-Position: refs/heads/master@{#14860} TBR=hta@webrtc.org,deadbeef@webrtc.org,hbos@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:627816, chromium:657856, chromium:657854 Committed: https://crrev.com/7eaa83622b19c7afa80139d3261e6bfbe2cae6ec Cr-Commit-Position: refs/heads/master@{#14863}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -472 lines) Patch
M webrtc/api/rtcstatscollector.h View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/api/rtcstatscollector.cc View 9 chunks +4 lines, -136 lines 0 comments Download
M webrtc/api/rtcstatscollector_unittest.cc View 10 chunks +4 lines, -143 lines 0 comments Download
M webrtc/api/stats/rtcstats.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/api/stats/rtcstats_objects.h View 2 chunks +1 line, -57 lines 0 comments Download
M webrtc/api/stats/rtcstatsreport.h View 3 chunks +2 lines, -9 lines 0 comments Download
M webrtc/stats/rtcstats.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/stats/rtcstats_objects.cc View 1 chunk +0 lines, -86 lines 0 comments Download
M webrtc/stats/rtcstatsreport.cc View 4 chunks +3 lines, -23 lines 0 comments Download
M webrtc/stats/rtcstatsreport_unittest.cc View 3 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
perkj_webrtc
Created Revert of RTCOutboundRTPStreamStats added.
4 years, 1 month ago (2016-11-01 06:52:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2465223002/1
4 years, 1 month ago (2016-11-01 06:52:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-01 06:52:28 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 06:52:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7eaa83622b19c7afa80139d3261e6bfbe2cae6ec
Cr-Commit-Position: refs/heads/master@{#14863}

Powered by Google App Engine
This is Rietveld 408576698