Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: webrtc/api/stats/rtcstats_objects.h

Issue 2465223002: Revert of RTCOutboundRTPStreamStats added. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/stats/rtcstats.h ('k') | webrtc/api/stats/rtcstatsreport.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/stats/rtcstats_objects.h
diff --git a/webrtc/api/stats/rtcstats_objects.h b/webrtc/api/stats/rtcstats_objects.h
index 232e66b388e62524acb27f68d2cdb9220cdce339..3684e278c3f6812e6a83c0d9b0d503e234b2562b 100644
--- a/webrtc/api/stats/rtcstats_objects.h
+++ b/webrtc/api/stats/rtcstats_objects.h
@@ -82,7 +82,7 @@
// https://w3c.github.io/webrtc-stats/#candidatepair-dict*
// TODO(hbos): Finish implementation. Tracking bug crbug.com/633550
-class RTCIceCandidatePairStats final : public RTCStats {
+class RTCIceCandidatePairStats : public RTCStats {
public:
WEBRTC_RTCSTATS_DECL();
@@ -202,62 +202,6 @@
RTCStatsMember<uint32_t> data_channels_closed;
};
-// https://w3c.github.io/webrtc-stats/#streamstats-dict*
-// TODO(hbos): Finish implementation. Tracking bug crbug.com/657854
-class RTCRTPStreamStats : public RTCStats {
- public:
- WEBRTC_RTCSTATS_DECL();
-
- RTCRTPStreamStats(const RTCRTPStreamStats& other);
- ~RTCRTPStreamStats() override;
-
- RTCStatsMember<std::string> ssrc;
- // TODO(hbos): When the remote case is supported |RTCStatsCollector| needs to
- // set this. crbug.com/657855, 657856
- RTCStatsMember<std::string> associate_stats_id;
- // TODO(hbos): Remote case not supported by |RTCStatsCollector|.
- // crbug.com/657855, 657856
- RTCStatsMember<bool> is_remote; // = false
- RTCStatsMember<std::string> media_type;
- // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657854, 659137
- RTCStatsMember<std::string> media_track_id;
- RTCStatsMember<std::string> transport_id;
- // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657854, 659117
- RTCStatsMember<std::string> codec_id;
- // FIR and PLI counts are only defined for |media_type == "video"|.
- RTCStatsMember<uint32_t> fir_count;
- RTCStatsMember<uint32_t> pli_count;
- // TODO(hbos): NACK count should be collected by |RTCStatsCollector| for both
- // audio and video but is only defined in the "video" case. crbug.com/657856
- RTCStatsMember<uint32_t> nack_count;
- // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657854
- // SLI count is only defined for |media_type == "video"|.
- RTCStatsMember<uint32_t> sli_count;
-
- protected:
- RTCRTPStreamStats(const std::string& id, int64_t timestamp_us);
- RTCRTPStreamStats(std::string&& id, int64_t timestamp_us);
-};
-
-// https://w3c.github.io/webrtc-stats/#outboundrtpstats-dict*
-// TODO(hbos): Finish implementation and support the remote case
-// |is_remote = true|. Tracking bug crbug.com/657856
-class RTCOutboundRTPStreamStats final : public RTCRTPStreamStats {
- public:
- WEBRTC_RTCSTATS_DECL();
-
- RTCOutboundRTPStreamStats(const std::string& id, int64_t timestamp_us);
- RTCOutboundRTPStreamStats(std::string&& id, int64_t timestamp_us);
- RTCOutboundRTPStreamStats(const RTCOutboundRTPStreamStats& other);
- ~RTCOutboundRTPStreamStats() override;
-
- RTCStatsMember<uint32_t> packets_sent;
- RTCStatsMember<uint64_t> bytes_sent;
- // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657856
- RTCStatsMember<double> target_bitrate;
- RTCStatsMember<double> round_trip_time;
-};
-
// https://w3c.github.io/webrtc-stats/#transportstats-dict*
class RTCTransportStats final : public RTCStats {
public:
« no previous file with comments | « webrtc/api/stats/rtcstats.h ('k') | webrtc/api/stats/rtcstatsreport.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698