Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2464073002: Make video denoiser tests standalone, not using the VideoProcessingTest fixture. (Closed)

Created:
4 years, 1 month ago by nisse-webrtc
Modified:
4 years, 1 month ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make video denoiser tests standalone, not using the VideoProcessingTest fixture. BUG=None Committed: https://crrev.com/0dbcfa51a27dc3efa936c2facc49e9fe9c066531 Cr-Commit-Position: refs/heads/master@{#14890}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Replace NULL --> nullptr. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M webrtc/modules/video_processing/test/denoiser_test.cc View 1 6 chunks +18 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
nisse-webrtc
PTAL.
4 years, 1 month ago (2016-11-01 09:42:04 UTC) #2
stefan-webrtc
lgtm https://codereview.webrtc.org/2464073002/diff/1/webrtc/modules/video_processing/test/denoiser_test.cc File webrtc/modules/video_processing/test/denoiser_test.cc (right): https://codereview.webrtc.org/2464073002/diff/1/webrtc/modules/video_processing/test/denoiser_test.cc#newcode135 webrtc/modules/video_processing/test/denoiser_test.cc:135: ASSERT_TRUE(source_file != NULL) nullptr
4 years, 1 month ago (2016-11-02 13:22:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2464073002/20001
4 years, 1 month ago (2016-11-02 13:51:03 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-02 14:11:06 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 14:11:17 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0dbcfa51a27dc3efa936c2facc49e9fe9c066531
Cr-Commit-Position: refs/heads/master@{#14890}

Powered by Google App Engine
This is Rietveld 408576698