Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: webrtc/modules/video_processing/test/denoiser_test.cc

Issue 2464073002: Make video denoiser tests standalone, not using the VideoProcessingTest fixture. (Closed)
Patch Set: Replace NULL --> nullptr. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include <string.h> 11 #include <string.h>
12 12
13 #include <memory> 13 #include <memory>
14 14
15 #include "webrtc/common_video/libyuv/include/webrtc_libyuv.h" 15 #include "webrtc/common_video/include/video_frame_buffer.h"
16 #include "webrtc/modules/video_processing/include/video_processing.h"
17 #include "webrtc/modules/video_processing/test/video_processing_unittest.h"
18 #include "webrtc/modules/video_processing/video_denoiser.h" 16 #include "webrtc/modules/video_processing/video_denoiser.h"
17 #include "webrtc/test/gtest.h"
19 #include "webrtc/test/frame_utils.h" 18 #include "webrtc/test/frame_utils.h"
19 #include "webrtc/test/testsupport/fileutils.h"
20 20
21 namespace webrtc { 21 namespace webrtc {
22 22
23 TEST_F(VideoProcessingTest, CopyMem) { 23 TEST(VideoDenoiserTest, CopyMem) {
24 std::unique_ptr<DenoiserFilter> df_c(DenoiserFilter::Create(false, nullptr)); 24 std::unique_ptr<DenoiserFilter> df_c(DenoiserFilter::Create(false, nullptr));
25 std::unique_ptr<DenoiserFilter> df_sse_neon( 25 std::unique_ptr<DenoiserFilter> df_sse_neon(
26 DenoiserFilter::Create(true, nullptr)); 26 DenoiserFilter::Create(true, nullptr));
27 uint8_t src[16 * 16], dst[16 * 16]; 27 uint8_t src[16 * 16], dst[16 * 16];
28 for (int i = 0; i < 16; ++i) { 28 for (int i = 0; i < 16; ++i) {
29 for (int j = 0; j < 16; ++j) { 29 for (int j = 0; j < 16; ++j) {
30 src[i * 16 + j] = i * 16 + j; 30 src[i * 16 + j] = i * 16 + j;
31 } 31 }
32 } 32 }
33 33
34 memset(dst, 0, 16 * 16); 34 memset(dst, 0, 16 * 16);
35 df_c->CopyMem16x16(src, 16, dst, 16); 35 df_c->CopyMem16x16(src, 16, dst, 16);
36 EXPECT_EQ(0, memcmp(src, dst, 16 * 16)); 36 EXPECT_EQ(0, memcmp(src, dst, 16 * 16));
37 37
38 memset(dst, 0, 16 * 16); 38 memset(dst, 0, 16 * 16);
39 df_sse_neon->CopyMem16x16(src, 16, dst, 16); 39 df_sse_neon->CopyMem16x16(src, 16, dst, 16);
40 EXPECT_EQ(0, memcmp(src, dst, 16 * 16)); 40 EXPECT_EQ(0, memcmp(src, dst, 16 * 16));
41 } 41 }
42 42
43 TEST_F(VideoProcessingTest, Variance) { 43 TEST(VideoDenoiserTest, Variance) {
44 std::unique_ptr<DenoiserFilter> df_c(DenoiserFilter::Create(false, nullptr)); 44 std::unique_ptr<DenoiserFilter> df_c(DenoiserFilter::Create(false, nullptr));
45 std::unique_ptr<DenoiserFilter> df_sse_neon( 45 std::unique_ptr<DenoiserFilter> df_sse_neon(
46 DenoiserFilter::Create(true, nullptr)); 46 DenoiserFilter::Create(true, nullptr));
47 uint8_t src[16 * 16], dst[16 * 16]; 47 uint8_t src[16 * 16], dst[16 * 16];
48 uint32_t sum = 0, sse = 0, var; 48 uint32_t sum = 0, sse = 0, var;
49 for (int i = 0; i < 16; ++i) { 49 for (int i = 0; i < 16; ++i) {
50 for (int j = 0; j < 16; ++j) { 50 for (int j = 0; j < 16; ++j) {
51 src[i * 16 + j] = i * 16 + j; 51 src[i * 16 + j] = i * 16 + j;
52 } 52 }
53 } 53 }
54 // Compute the 16x8 variance of the 16x16 block. 54 // Compute the 16x8 variance of the 16x16 block.
55 for (int i = 0; i < 8; ++i) { 55 for (int i = 0; i < 8; ++i) {
56 for (int j = 0; j < 16; ++j) { 56 for (int j = 0; j < 16; ++j) {
57 sum += (i * 32 + j); 57 sum += (i * 32 + j);
58 sse += (i * 32 + j) * (i * 32 + j); 58 sse += (i * 32 + j) * (i * 32 + j);
59 } 59 }
60 } 60 }
61 var = sse - ((sum * sum) >> 7); 61 var = sse - ((sum * sum) >> 7);
62 memset(dst, 0, 16 * 16); 62 memset(dst, 0, 16 * 16);
63 EXPECT_EQ(var, df_c->Variance16x8(src, 16, dst, 16, &sse)); 63 EXPECT_EQ(var, df_c->Variance16x8(src, 16, dst, 16, &sse));
64 EXPECT_EQ(var, df_sse_neon->Variance16x8(src, 16, dst, 16, &sse)); 64 EXPECT_EQ(var, df_sse_neon->Variance16x8(src, 16, dst, 16, &sse));
65 } 65 }
66 66
67 TEST_F(VideoProcessingTest, MbDenoise) { 67 TEST(VideoDenoiserTest, MbDenoise) {
68 std::unique_ptr<DenoiserFilter> df_c(DenoiserFilter::Create(false, nullptr)); 68 std::unique_ptr<DenoiserFilter> df_c(DenoiserFilter::Create(false, nullptr));
69 std::unique_ptr<DenoiserFilter> df_sse_neon( 69 std::unique_ptr<DenoiserFilter> df_sse_neon(
70 DenoiserFilter::Create(true, nullptr)); 70 DenoiserFilter::Create(true, nullptr));
71 uint8_t running_src[16 * 16], src[16 * 16]; 71 uint8_t running_src[16 * 16], src[16 * 16];
72 uint8_t dst[16 * 16], dst_sse_neon[16 * 16]; 72 uint8_t dst[16 * 16], dst_sse_neon[16 * 16];
73 73
74 // Test case: |diff| <= |3 + shift_inc1| 74 // Test case: |diff| <= |3 + shift_inc1|
75 for (int i = 0; i < 16; ++i) { 75 for (int i = 0; i < 16; ++i) {
76 for (int j = 0; j < 16; ++j) { 76 for (int j = 0; j < 16; ++j) {
77 running_src[i * 16 + j] = i * 11 + j; 77 running_src[i * 16 + j] = i * 11 + j;
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 } 118 }
119 } 119 }
120 memset(dst, 0, 16 * 16); 120 memset(dst, 0, 16 * 16);
121 DenoiserDecision decision = 121 DenoiserDecision decision =
122 df_c->MbDenoise(running_src, 16, dst, 16, src, 16, 0, 1); 122 df_c->MbDenoise(running_src, 16, dst, 16, src, 16, 0, 1);
123 EXPECT_EQ(COPY_BLOCK, decision); 123 EXPECT_EQ(COPY_BLOCK, decision);
124 decision = df_sse_neon->MbDenoise(running_src, 16, dst, 16, src, 16, 0, 1); 124 decision = df_sse_neon->MbDenoise(running_src, 16, dst, 16, src, 16, 0, 1);
125 EXPECT_EQ(COPY_BLOCK, decision); 125 EXPECT_EQ(COPY_BLOCK, decision);
126 } 126 }
127 127
128 // TODO(nisse): Refactor to not use test fixture. Can use some static 128 TEST(VideoDenoiserTest, Denoiser) {
129 // helper method to open the input file. 129 const int kWidth = 352;
130 TEST_F(VideoProcessingTest, Denoiser) { 130 const int kHeight = 288;
131
132 const std::string video_file =
133 webrtc::test::ResourcePath("foreman_cif", "yuv");
134 FILE* source_file = fopen(video_file.c_str(), "rb");
135 ASSERT_TRUE(source_file != nullptr)
136 << "Cannot open source file: " << video_file;
137
131 // Used in swap buffer. 138 // Used in swap buffer.
132 int denoised_frame_toggle = 0; 139 int denoised_frame_toggle = 0;
133 // Create pure C denoiser. 140 // Create pure C denoiser.
134 VideoDenoiser denoiser_c(false); 141 VideoDenoiser denoiser_c(false);
135 // Create SSE or NEON denoiser. 142 // Create SSE or NEON denoiser.
136 VideoDenoiser denoiser_sse_neon(true); 143 VideoDenoiser denoiser_sse_neon(true);
137 rtc::scoped_refptr<I420Buffer> denoised_frame_c; 144 rtc::scoped_refptr<I420Buffer> denoised_frame_c;
138 rtc::scoped_refptr<I420Buffer> denoised_frame_prev_c; 145 rtc::scoped_refptr<I420Buffer> denoised_frame_prev_c;
139 rtc::scoped_refptr<I420Buffer> denoised_frame_sse_neon; 146 rtc::scoped_refptr<I420Buffer> denoised_frame_sse_neon;
140 rtc::scoped_refptr<I420Buffer> denoised_frame_prev_sse_neon; 147 rtc::scoped_refptr<I420Buffer> denoised_frame_prev_sse_neon;
141 148
142 for (;;) { 149 for (;;) {
143 rtc::scoped_refptr<VideoFrameBuffer> video_frame_buffer( 150 rtc::scoped_refptr<VideoFrameBuffer> video_frame_buffer(
144 test::ReadI420Buffer(width_, height_, source_file_)); 151 test::ReadI420Buffer(kWidth, kHeight, source_file));
145 if (!video_frame_buffer) 152 if (!video_frame_buffer)
146 break; 153 break;
147 154
148 rtc::scoped_refptr<I420Buffer>* p_denoised_c = &denoised_frame_c; 155 rtc::scoped_refptr<I420Buffer>* p_denoised_c = &denoised_frame_c;
149 rtc::scoped_refptr<I420Buffer>* p_denoised_prev_c = &denoised_frame_prev_c; 156 rtc::scoped_refptr<I420Buffer>* p_denoised_prev_c = &denoised_frame_prev_c;
150 rtc::scoped_refptr<I420Buffer>* p_denoised_sse_neon = 157 rtc::scoped_refptr<I420Buffer>* p_denoised_sse_neon =
151 &denoised_frame_sse_neon; 158 &denoised_frame_sse_neon;
152 rtc::scoped_refptr<I420Buffer>* p_denoised_prev_sse_neon = 159 rtc::scoped_refptr<I420Buffer>* p_denoised_prev_sse_neon =
153 &denoised_frame_prev_sse_neon; 160 &denoised_frame_prev_sse_neon;
154 // Swap the buffer to save one memcpy in DenoiseFrame. 161 // Swap the buffer to save one memcpy in DenoiseFrame.
155 if (denoised_frame_toggle) { 162 if (denoised_frame_toggle) {
156 p_denoised_c = &denoised_frame_prev_c; 163 p_denoised_c = &denoised_frame_prev_c;
157 p_denoised_prev_c = &denoised_frame_c; 164 p_denoised_prev_c = &denoised_frame_c;
158 p_denoised_sse_neon = &denoised_frame_prev_sse_neon; 165 p_denoised_sse_neon = &denoised_frame_prev_sse_neon;
159 p_denoised_prev_sse_neon = &denoised_frame_sse_neon; 166 p_denoised_prev_sse_neon = &denoised_frame_sse_neon;
160 } 167 }
161 denoiser_c.DenoiseFrame(video_frame_buffer, 168 denoiser_c.DenoiseFrame(video_frame_buffer,
162 p_denoised_c, p_denoised_prev_c, 169 p_denoised_c, p_denoised_prev_c,
163 false); 170 false);
164 denoiser_sse_neon.DenoiseFrame(video_frame_buffer, 171 denoiser_sse_neon.DenoiseFrame(video_frame_buffer,
165 p_denoised_sse_neon, 172 p_denoised_sse_neon,
166 p_denoised_prev_sse_neon, false); 173 p_denoised_prev_sse_neon, false);
167 // Invert the flag. 174 // Invert the flag.
168 denoised_frame_toggle ^= 1; 175 denoised_frame_toggle ^= 1;
169 // Denoising results should be the same for C and SSE/NEON denoiser. 176 // Denoising results should be the same for C and SSE/NEON denoiser.
170 ASSERT_TRUE(test::FrameBufsEqual(*p_denoised_c, *p_denoised_sse_neon)); 177 ASSERT_TRUE(test::FrameBufsEqual(*p_denoised_c, *p_denoised_sse_neon));
171 } 178 }
172 ASSERT_NE(0, feof(source_file_)) << "Error reading source file"; 179 ASSERT_NE(0, feof(source_file)) << "Error reading source file";
173 } 180 }
174 181
175 } // namespace webrtc 182 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698