Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1117)

Issue 2463733002: Revert of "Separating video settings in VideoQualityTest". (Closed)

Created:
4 years, 1 month ago by minyue-webrtc
Modified:
4 years, 1 month ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, perkj_webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of "Separating video settings in VideoQualityTest". (patchset #4 id:60001 of https://codereview.webrtc.org/2314403007/ ) Reason for revert: Some parameters were not treated correctly. Will redo some parts. Original issue's description: > Reland of "Separating video settings in VideoQualityTest". > > Earlier trial of landing: https://codereview.webrtc.org/2312613003 > > Reverted in https://codereview.webrtc.org/2325723002 > > BUG=webrtc:6609 > > Committed: https://crrev.com/16b6d6dc5b367746a9f910d1cebf9f65e8dd2c7f > Cr-Commit-Position: refs/heads/master@{#14785} TBR=stefan@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6609 Committed: https://crrev.com/9aa78832f99eb0b76bb4655194fec5c291918187 Cr-Commit-Position: refs/heads/master@{#14838}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -223 lines) Patch
M webrtc/video/full_stack.cc View 11 chunks +97 lines, -93 lines 0 comments Download
M webrtc/video/screenshare_loopback.cc View 1 chunk +17 lines, -17 lines 0 comments Download
M webrtc/video/video_loopback.cc View 1 chunk +18 lines, -17 lines 0 comments Download
M webrtc/video/video_quality_test.h View 3 chunks +9 lines, -13 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 29 chunks +72 lines, -83 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
minyue-webrtc
Created Revert of "Separating video settings in VideoQualityTest".
4 years, 1 month ago (2016-10-31 09:24:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2463733002/1
4 years, 1 month ago (2016-10-31 09:24:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 10:23:03 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 10:23:13 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9aa78832f99eb0b76bb4655194fec5c291918187
Cr-Commit-Position: refs/heads/master@{#14838}

Powered by Google App Engine
This is Rietveld 408576698