Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2325723002: Revert of Separating video settings in VideoQualityTest. (Closed)

Created:
4 years, 3 months ago by kjellander_webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, perkj_webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Separating video settings in VideoQualityTest. (patchset #2 id:20001 of https://codereview.webrtc.org/2312613003/ ) Reason for revert: Breaks webrtc_perf_tests on Windows, Mac and Linux (that test don't run on trybots): https://build.chromium.org/p/client.webrtc/builders/Linux64%20Release%20%5Blarge%20tests%5D/builds/8841/steps/webrtc_perf_tests/logs/stdio Example: [ RUN ] FullStackTest.ForemanCifWithoutPacketLossVp9 # Fatal error in ../../webrtc/video/video_quality_test.cc, line 1056 # last system error: 34 # Check failed: !params_.audio.enabled Original issue's description: > Separating video settings in VideoQualityTest. > > This is a simple refactoring of VideoQualityTest. It will help in adding audio related settings to VideoQualityTest. > > BUG= > > Committed: https://crrev.com/f07fb0013164bdb031dcc88dc83365a27643b2d9 > Cr-Commit-Position: refs/heads/master@{#14139} TBR=stefan@webrtc.org,minyue@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/5865f48dcb5f14346876428fd0f3a66473839b0c Cr-Commit-Position: refs/heads/master@{#14142}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -203 lines) Patch
M webrtc/video/full_stack.cc View 11 chunks +97 lines, -92 lines 0 comments Download
M webrtc/video/screenshare_loopback.cc View 1 chunk +8 lines, -16 lines 0 comments Download
M webrtc/video/video_loopback.cc View 1 chunk +9 lines, -16 lines 0 comments Download
M webrtc/video/video_quality_test.h View 3 chunks +9 lines, -11 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 28 chunks +70 lines, -68 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kjellander_webrtc
Created Revert of Separating video settings in VideoQualityTest.
4 years, 3 months ago (2016-09-08 17:52:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2325723002/1
4 years, 3 months ago (2016-09-08 17:52:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 17:52:41 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 17:52:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5865f48dcb5f14346876428fd0f3a66473839b0c
Cr-Commit-Position: refs/heads/master@{#14142}

Powered by Google App Engine
This is Rietveld 408576698