Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2458993002: Reland of New statistics interface for APM (Closed)

Created:
4 years, 1 month ago by ivoc
Modified:
4 years, 1 month ago
Reviewers:
the sun, peah-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, henrika_webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Original CL: https://codereview.webrtc.org/2433153003/, commit 8b8d3e4c30e8ea3846b58dfd36d1fd35a7799df4. Revert CL: https://codereview.webrtc.org/2456333002/, commit 48dfab5c58119a4e65c52506ed55f8de79725bcf. The new function on the APM interface is no longer pure virtual. BUG=webrtc:6525 TBR=solenberg@webrtc.org,peah@webrtc.org Committed: https://crrev.com/3e9a53760101a5b14d771ee1152b2988685d630e Cr-Commit-Position: refs/heads/master@{#14827}

Patch Set 1 : Initial CL #

Patch Set 2 : Made GetStatistics() non-pure virtual. #

Patch Set 3 : Added implementation of the new non-pure interface function. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -26 lines) Patch
M webrtc/modules/audio_processing/audio_processing_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 1 2 2 chunks +26 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_unittest.cc View 1 2 3 chunks +12 lines, -7 lines 0 comments Download
M webrtc/modules/audio_processing/echo_cancellation_impl.h View 2 chunks +14 lines, -6 lines 0 comments Download
M webrtc/modules/audio_processing/echo_cancellation_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/include/audio_processing.h View 1 4 chunks +72 lines, -8 lines 0 comments Download
M webrtc/modules/audio_processing/include/mock_audio_processing.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/extended/ec_metrics_test.cc View 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2458993002/20001
4 years, 1 month ago (2016-10-28 13:49:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios64_sim_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/11980) ios_dbg on master.tryserver.webrtc (JOB_FAILED, ...
4 years, 1 month ago (2016-10-28 13:54:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2458993002/40001
4 years, 1 month ago (2016-10-28 14:32:20 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-28 14:55:36 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 14:55:44 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3e9a53760101a5b14d771ee1152b2988685d630e
Cr-Commit-Position: refs/heads/master@{#14827}

Powered by Google App Engine
This is Rietveld 408576698