Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: webrtc/voice_engine/test/auto_test/extended/ec_metrics_test.cc

Issue 2458993002: Reland of New statistics interface for APM (Closed)
Patch Set: Added implementation of the new non-pure interface function. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/audio_processing/include/mock_audio_processing.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/voice_engine/test/auto_test/extended/ec_metrics_test.cc
diff --git a/webrtc/voice_engine/test/auto_test/extended/ec_metrics_test.cc b/webrtc/voice_engine/test/auto_test/extended/ec_metrics_test.cc
index a202aea2801ab214ae6c0569116518d229df7a1a..758a0850ed0cbfecbdb73d897c3a064d9f591162 100644
--- a/webrtc/voice_engine/test/auto_test/extended/ec_metrics_test.cc
+++ b/webrtc/voice_engine/test/auto_test/extended/ec_metrics_test.cc
@@ -13,13 +13,19 @@
class EcMetricsTest : public AfterStreamingFixture {
};
-TEST_F(EcMetricsTest, EcMetricsAreOffByDefault) {
- bool enabled = true;
+TEST_F(EcMetricsTest, EcMetricsAreOnByDefault) {
+ // AEC must be enabled fist.
+ EXPECT_EQ(0, voe_apm_->SetEcStatus(true, webrtc::kEcAec));
+
+ bool enabled = false;
EXPECT_EQ(0, voe_apm_->GetEcMetricsStatus(enabled));
- EXPECT_FALSE(enabled);
+ EXPECT_TRUE(enabled);
}
TEST_F(EcMetricsTest, CanEnableAndDisableEcMetrics) {
+ // AEC must be enabled fist.
+ EXPECT_EQ(0, voe_apm_->SetEcStatus(true, webrtc::kEcAec));
+
EXPECT_EQ(0, voe_apm_->SetEcMetricsStatus(true));
bool ec_on = false;
EXPECT_EQ(0, voe_apm_->GetEcMetricsStatus(ec_on));
« no previous file with comments | « webrtc/modules/audio_processing/include/mock_audio_processing.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698