Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2457783003: Added offline data logpoints and logging functionality to the gain controller (Closed)

Created:
4 years, 1 month ago by peah-webrtc
Modified:
4 years, 1 month ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

In order to be able to analyze the AGC behavior on aecdump recordings in an efficient manner, it is important to be able to use a standardized analysis script. For this to be feasible, data log points should be present. This CL adds those logpoints as well as the framework needed to for those to work. BUG=webrtc:6564 Committed: https://crrev.com/135259ac8fac1fd88e948742e6ab473425a43d88 Cr-Commit-Position: refs/heads/master@{#14812}

Patch Set 1 #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -8 lines) Patch
M webrtc/modules/audio_processing/audio_processing_impl.cc View 3 chunks +4 lines, -3 lines 2 comments Download
M webrtc/modules/audio_processing/gain_control_for_experimental_agc.h View 3 chunks +10 lines, -3 lines 1 comment Download
M webrtc/modules/audio_processing/gain_control_for_experimental_agc.cc View 3 chunks +18 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/gain_control_impl.h View 3 chunks +4 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/gain_control_impl.cc View 5 chunks +8 lines, -0 lines 4 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
peah-webrtc
https://codereview.webrtc.org/2457783003/diff/1/webrtc/modules/audio_processing/audio_processing_impl.cc File webrtc/modules/audio_processing/audio_processing_impl.cc (right): https://codereview.webrtc.org/2457783003/diff/1/webrtc/modules/audio_processing/audio_processing_impl.cc#newcode446 webrtc/modules/audio_processing/audio_processing_impl.cc:446: I moved the initialization of the gain_control to be ...
4 years, 1 month ago (2016-10-28 08:37:50 UTC) #3
ivoc
LGTM with two questions below. https://codereview.webrtc.org/2457783003/diff/1/webrtc/modules/audio_processing/gain_control_impl.cc File webrtc/modules/audio_processing/gain_control_impl.cc (right): https://codereview.webrtc.org/2457783003/diff/1/webrtc/modules/audio_processing/gain_control_impl.cc#newcode94 webrtc/modules/audio_processing/gain_control_impl.cc:94: data_dumper_(new ApmDataDumper(instance_counter_)), The experimental ...
4 years, 1 month ago (2016-10-28 09:20:10 UTC) #5
peah-webrtc
https://codereview.webrtc.org/2457783003/diff/1/webrtc/modules/audio_processing/gain_control_impl.cc File webrtc/modules/audio_processing/gain_control_impl.cc (right): https://codereview.webrtc.org/2457783003/diff/1/webrtc/modules/audio_processing/gain_control_impl.cc#newcode94 webrtc/modules/audio_processing/gain_control_impl.cc:94: data_dumper_(new ApmDataDumper(instance_counter_)), On 2016/10/28 09:20:10, ivoc wrote: > The ...
4 years, 1 month ago (2016-10-28 09:43:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2457783003/1
4 years, 1 month ago (2016-10-28 09:43:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 10:12:14 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 10:12:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/135259ac8fac1fd88e948742e6ab473425a43d88
Cr-Commit-Position: refs/heads/master@{#14812}

Powered by Google App Engine
This is Rietveld 408576698