Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 2449043008: Added calling of the stream_analog_level api in audioproc_f (Closed)

Created:
4 years, 1 month ago by peah-webrtc
Modified:
4 years, 1 month ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Added calling of the stream_analog_level api in audioproc_f The test program audioproc_f does not call the stream_analog_level method. This should be done do 1) Ensure that proper log output is produced when reproducing a call. 2) Ensure that this method is properly tested. 3) Ensure that the correct side-effects are triggered (this method is not const). BUG=webrtc:6564 Committed: https://crrev.com/f005a000943f4f708662080c122c9c421793224d Cr-Commit-Position: refs/heads/master@{#14817}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M webrtc/modules/audio_processing/test/aec_dump_based_simulator.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/test/aec_dump_based_simulator.cc View 3 chunks +12 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/test/wav_based_simulator.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
peah-webrtc
4 years, 1 month ago (2016-10-28 09:12:38 UTC) #2
ivoc
LGTM. I don't see any side-effects or log messages in the definition of stream_analog_level(). Is ...
4 years, 1 month ago (2016-10-28 10:20:40 UTC) #3
peah-webrtc
On 2016/10/28 10:20:40, ivoc wrote: > LGTM. I don't see any side-effects or log messages ...
4 years, 1 month ago (2016-10-28 10:45:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2449043008/1
4 years, 1 month ago (2016-10-28 10:45:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 12:02:37 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 12:02:47 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f005a000943f4f708662080c122c9c421793224d
Cr-Commit-Position: refs/heads/master@{#14817}

Powered by Google App Engine
This is Rietveld 408576698