Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: webrtc/api/stats/rtcstats_objects.h

Issue 2456463002: RTCOutboundRTPStreamStats added. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/stats/rtcstats_objects.h
diff --git a/webrtc/api/stats/rtcstats_objects.h b/webrtc/api/stats/rtcstats_objects.h
index 3684e278c3f6812e6a83c0d9b0d503e234b2562b..65a70cef7a1ea63a610fb4b504d3b2e2e8500eec 100644
--- a/webrtc/api/stats/rtcstats_objects.h
+++ b/webrtc/api/stats/rtcstats_objects.h
@@ -82,7 +82,7 @@ class RTCDataChannelStats final : public RTCStats {
// https://w3c.github.io/webrtc-stats/#candidatepair-dict*
// TODO(hbos): Finish implementation. Tracking bug crbug.com/633550
-class RTCIceCandidatePairStats : public RTCStats {
+class RTCIceCandidatePairStats final : public RTCStats {
public:
WEBRTC_RTCSTATS_DECL();
@@ -202,6 +202,60 @@ class RTCPeerConnectionStats final : public RTCStats {
RTCStatsMember<uint32_t> data_channels_closed;
};
+// https://w3c.github.io/webrtc-stats/#streamstats-dict*
+// TODO(hbos): Finish implementation. Tracking bug crbug.com/657854
+class RTCRTPStreamStats : public RTCStats {
+ public:
+ WEBRTC_RTCSTATS_DECL();
+
+ RTCRTPStreamStats(const RTCRTPStreamStats& other);
+ ~RTCRTPStreamStats() override;
+
+ RTCStatsMember<std::string> ssrc;
+ // TODO(hbos): When the remote case is supported |RTCStatsCollector| needs to
+ // set this. crbug.com/657855, 657856
+ RTCStatsMember<std::string> associate_stats_id;
+ // TODO(hbos): Remote case not supported by |RTCStatsCollector|.
+ // crbug.com/657855, 657856
+ RTCStatsMember<bool> is_remote; // = false
+ RTCStatsMember<std::string> media_type;
+ // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657854, 659137
+ RTCStatsMember<std::string> media_track_id;
+ RTCStatsMember<std::string> transport_id;
+ // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657854, 659117
+ RTCStatsMember<std::string> codec_id;
+ // FIR, PLI, NACK and SLI counts are only defined for |media_type == "video"|.
+ RTCStatsMember<uint32_t> fir_count;
+ RTCStatsMember<uint32_t> pli_count;
+ RTCStatsMember<uint32_t> nack_count;
+ // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657854
+ RTCStatsMember<uint32_t> sli_count;
+
+ protected:
+ RTCRTPStreamStats(const std::string& id, int64_t timestamp_us);
+ RTCRTPStreamStats(std::string&& id, int64_t timestamp_us);
+};
+
+// https://w3c.github.io/webrtc-stats/#outboundrtpstats-dict*
+// TODO(hbos): Finish implementation and support the remote case
+// |is_remote = true|. Tracking bug crbug.com/657856
+class RTCOutboundRTPStreamStats final : public RTCRTPStreamStats {
+ public:
+ WEBRTC_RTCSTATS_DECL();
+
+ RTCOutboundRTPStreamStats(const std::string& id, int64_t timestamp_us);
+ RTCOutboundRTPStreamStats(std::string&& id, int64_t timestamp_us);
+ RTCOutboundRTPStreamStats(const RTCOutboundRTPStreamStats& other);
+ ~RTCOutboundRTPStreamStats() override;
+
+ RTCStatsMember<uint32_t> packets_sent;
+ RTCStatsMember<uint64_t> bytes_sent;
+ // TODO(hbos): Not collected in the "audio" case by |RTCStatsCollector|.
+ // crbug.com/657856
+ RTCStatsMember<double> target_bitrate;
+ RTCStatsMember<double> round_trip_time;
+};
+
// https://w3c.github.io/webrtc-stats/#transportstats-dict*
class RTCTransportStats final : public RTCStats {
public:

Powered by Google App Engine
This is Rietveld 408576698