Chromium Code Reviews| Index: webrtc/stats/rtcstatsreport_unittest.cc |
| diff --git a/webrtc/stats/rtcstatsreport_unittest.cc b/webrtc/stats/rtcstatsreport_unittest.cc |
| index 3bfbd44cba626b6c6accb1a16b598ae3209d0930..9b37a4ed2931161ec162aedd9eb20cf6866b7739 100644 |
| --- a/webrtc/stats/rtcstatsreport_unittest.cc |
| +++ b/webrtc/stats/rtcstatsreport_unittest.cc |
| @@ -59,7 +59,8 @@ WEBRTC_RTCSTATS_IMPL(RTCTestStats3, RTCStats, "test-stats-3", |
| &string); |
| TEST(RTCStatsReport, AddAndGetStats) { |
| - rtc::scoped_refptr<RTCStatsReport> report = RTCStatsReport::Create(); |
| + rtc::scoped_refptr<RTCStatsReport> report = RTCStatsReport::Create(1337); |
| + EXPECT_EQ(report->timestamp_us(), 1337u); |
|
hta-webrtc
2016/10/27 12:34:51
Style nit: Since you're using 1337 in 4 different
Taylor Brandstetter
2016/10/27 21:44:37
It's not really a magical number though; it's only
hbos
2016/10/28 09:42:37
Yeah it's a completely meaningless number. In the
|
| EXPECT_EQ(report->size(), static_cast<size_t>(0)); |
| report->AddStats(std::unique_ptr<RTCStats>(new RTCTestStats1("a0", 1))); |
| report->AddStats(std::unique_ptr<RTCStats>(new RTCTestStats1("a1", 2))); |
| @@ -92,7 +93,8 @@ TEST(RTCStatsReport, AddAndGetStats) { |
| } |
| TEST(RTCStatsReport, StatsOrder) { |
| - rtc::scoped_refptr<RTCStatsReport> report = RTCStatsReport::Create(); |
| + rtc::scoped_refptr<RTCStatsReport> report = RTCStatsReport::Create(1337); |
| + EXPECT_EQ(report->timestamp_us(), 1337u); |
| report->AddStats(std::unique_ptr<RTCStats>(new RTCTestStats1("C", 2))); |
| report->AddStats(std::unique_ptr<RTCStats>(new RTCTestStats1("D", 3))); |
| report->AddStats(std::unique_ptr<RTCStats>(new RTCTestStats2("B", 1))); |
| @@ -109,11 +111,13 @@ TEST(RTCStatsReport, StatsOrder) { |
| } |
| TEST(RTCStatsReport, TakeMembersFrom) { |
| - rtc::scoped_refptr<RTCStatsReport> a = RTCStatsReport::Create(); |
| + rtc::scoped_refptr<RTCStatsReport> a = RTCStatsReport::Create(1337); |
| + EXPECT_EQ(a->timestamp_us(), 1337u); |
| a->AddStats(std::unique_ptr<RTCStats>(new RTCTestStats1("B", 1))); |
| a->AddStats(std::unique_ptr<RTCStats>(new RTCTestStats1("C", 2))); |
| a->AddStats(std::unique_ptr<RTCStats>(new RTCTestStats1("E", 4))); |
| - rtc::scoped_refptr<RTCStatsReport> b = RTCStatsReport::Create(); |
| + rtc::scoped_refptr<RTCStatsReport> b = RTCStatsReport::Create(1337); |
| + EXPECT_EQ(b->timestamp_us(), 1337u); |
| b->AddStats(std::unique_ptr<RTCStats>(new RTCTestStats1("A", 0))); |
| b->AddStats(std::unique_ptr<RTCStats>(new RTCTestStats1("D", 3))); |
| b->AddStats(std::unique_ptr<RTCStats>(new RTCTestStats1("F", 5))); |