Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2456333002: Revert of New statistics interface for APM (Closed)

Created:
4 years, 1 month ago by ivoc
Modified:
4 years, 1 month ago
Reviewers:
the sun, peah-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of New statistics interface for APM (patchset #11 id:200001 of https://codereview.webrtc.org/2433153003/ ) Reason for revert: This CL breaks internal dependencies. Original issue's description: > New statistics interface for APM > > This adds functions to enable and retrieve statistics from APM. These functions are not yet called, which will happen in a follow-up CL. > > BUG=webrtc:6525 > > Committed: https://crrev.com/8b8d3e4c30e8ea3846b58dfd36d1fd35a7799df4 > Cr-Commit-Position: refs/heads/master@{#14810} TBR=peah@webrtc.org,solenberg@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6525 Committed: https://crrev.com/48dfab5c58119a4e65c52506ed55f8de79725bcf Cr-Commit-Position: refs/heads/master@{#14814}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -132 lines) Patch
M webrtc/modules/audio_processing/audio_processing_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 2 chunks +0 lines, -20 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_unittest.cc View 2 chunks +7 lines, -13 lines 0 comments Download
M webrtc/modules/audio_processing/echo_cancellation_impl.h View 2 chunks +6 lines, -14 lines 0 comments Download
M webrtc/modules/audio_processing/echo_cancellation_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/include/audio_processing.h View 4 chunks +8 lines, -71 lines 0 comments Download
M webrtc/modules/audio_processing/include/mock_audio_processing.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/voice_engine/test/auto_test/extended/ec_metrics_test.cc View 1 chunk +3 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ivoc
Created Revert of New statistics interface for APM
4 years, 1 month ago (2016-10-28 10:29:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2456333002/1
4 years, 1 month ago (2016-10-28 10:29:26 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 10:29:36 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 10:29:41 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48dfab5c58119a4e65c52506ed55f8de79725bcf
Cr-Commit-Position: refs/heads/master@{#14814}

Powered by Google App Engine
This is Rietveld 408576698