webrtc/modules/audio_processing/audio_processing_unittest.cc - Issue 2456333002: Revert of New statistics interface for APM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/audio_processing_unittest.cc

Issue 2456333002: Revert of New statistics interface for APM (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_processing/audio_processing_impl.cc ('k') | webrtc/modules/audio_processing/echo_cancellation_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/audio_processing_unittest.cc

diff --git a/webrtc/modules/audio_processing/audio_processing_unittest.cc b/webrtc/modules/audio_processing/audio_processing_unittest.cc

index f865c87c3baa54f72b491ab16675c212a2139df7..d4faa812055eac5a0f9808a89a3e06f7aa2a9763 100644

--- a/webrtc/modules/audio_processing/audio_processing_unittest.cc

+++ b/webrtc/modules/audio_processing/audio_processing_unittest.cc

@@ -929,25 +929,12 @@

EXPECT_EQ(apm_->kNotEnabledError,

apm_->echo_cancellation()->GetMetrics(&metrics));

- EXPECT_EQ(apm_->kNoError, apm_->echo_cancellation()->Enable(true));

- EXPECT_TRUE(apm_->echo_cancellation()->is_enabled());

EXPECT_EQ(apm_->kNoError,

apm_->echo_cancellation()->enable_metrics(true));

EXPECT_TRUE(apm_->echo_cancellation()->are_metrics_enabled());

EXPECT_EQ(apm_->kNoError,

apm_->echo_cancellation()->enable_metrics(false));

EXPECT_FALSE(apm_->echo_cancellation()->are_metrics_enabled());

- EXPECT_EQ(apm_->kNoError,

- apm_->echo_cancellation()->enable_delay_logging(true));

- EXPECT_TRUE(apm_->echo_cancellation()->is_delay_logging_enabled());

- EXPECT_EQ(apm_->kNoError,

- apm_->echo_cancellation()->enable_delay_logging(false));

- EXPECT_FALSE(apm_->echo_cancellation()->is_delay_logging_enabled());

- EXPECT_EQ(apm_->kNoError, apm_->echo_cancellation()->Enable(false));

- EXPECT_FALSE(apm_->echo_cancellation()->is_enabled());

int median = 0;

int std = 0;

@@ -955,6 +942,13 @@

EXPECT_EQ(apm_->kNotEnabledError,

apm_->echo_cancellation()->GetDelayMetrics(&median, &std,

&poor_fraction));

+ EXPECT_EQ(apm_->kNoError,

+ apm_->echo_cancellation()->enable_delay_logging(true));

+ EXPECT_TRUE(apm_->echo_cancellation()->is_delay_logging_enabled());

+ EXPECT_EQ(apm_->kNoError,

+ apm_->echo_cancellation()->enable_delay_logging(false));

+ EXPECT_FALSE(apm_->echo_cancellation()->is_delay_logging_enabled());

EXPECT_EQ(apm_->kNoError, apm_->echo_cancellation()->Enable(true));

EXPECT_TRUE(apm_->echo_cancellation()->is_enabled());