Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

Issue 2455963003: Simplify SetFecParameters signature. (Closed)
Patch Set: Return type int32_t replaced by bool and void. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
diff --git a/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h b/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
index 4dda74d3432b21b751fe497aae44f08e94955cb5..95cf65bb7c85d7bcbf640ebddf017a43e09ef65f 100644
--- a/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
+++ b/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
@@ -459,8 +459,10 @@ class RtpRtcp : public Module {
virtual void SetUlpfecConfig(int red_payload_type,
int ulpfec_payload_type) = 0;
- virtual int32_t SetFecParameters(const FecProtectionParams* delta_params,
- const FecProtectionParams* key_params) = 0;
+ // Set FEC rates, max frames before FEC is sent, and type of FEC masks.
+ // Returns false on failure.
+ virtual bool SetFecParameters(const FecProtectionParams& delta_params,
danilchap 2016/10/28 10:16:41 to avoid breaking dependant projects, keep the old
brandtr 2016/10/28 11:06:10 Done. Added implementation in rtp_rtcp_impl.cc, t
+ const FecProtectionParams& key_params) = 0;
// Set method for requestion a new key frame.
// Returns -1 on failure else 0.

Powered by Google App Engine
This is Rietveld 408576698