Clean up abs-send-time for audio.

Clean up abs-send-time for audio.

BUG=None

Committed: https://crrev.com/b521aa704f75888a68edb6b5b046a0dce7d56f51
Cr-Commit-Position: refs/heads/master@{#14870}

[stefan-webrtc, 2016-10-27 14:59:02]

stefan@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[the sun, 2016-10-27 16:09:17]

https://codereview.webrtc.org/2455013003/diff/40001/webrtc/audio/audio_receiv...
File webrtc/audio/audio_receive_stream_unittest.cc (left):

https://codereview.webrtc.org/2455013003/diff/40001/webrtc/audio/audio_receiv...
webrtc/audio/audio_receive_stream_unittest.cc:128:
RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
Add audio level instead, and keep the test of ToString().

https://codereview.webrtc.org/2455013003/diff/40001/webrtc/audio/audio_send_s...
File webrtc/audio/audio_send_stream_unittest.cc (left):

https://codereview.webrtc.org/2455013003/diff/40001/webrtc/audio/audio_send_s...
webrtc/audio/audio_send_stream_unittest.cc:123:
RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
Same here - add audiolevel, or some other extension, to test ToString().

https://codereview.webrtc.org/2455013003/diff/40001/webrtc/voice_engine/chann...
File webrtc/voice_engine/channel_proxy.h (left):

https://codereview.webrtc.org/2455013003/diff/40001/webrtc/voice_engine/chann...
webrtc/voice_engine/channel_proxy.h:55: virtual void
SetSendAbsoluteSenderTimeStatus(bool enable, int id);
There's a mock_channel_proxy which you should update too.

https://codereview.webrtc.org/2455013003/diff/40001/webrtc/voice_engine/inclu...
File webrtc/voice_engine/include/voe_rtp_rtcp.h (left):

https://codereview.webrtc.org/2455013003/diff/40001/webrtc/voice_engine/inclu...
webrtc/voice_engine/include/voe_rtp_rtcp.h:137: virtual int
SetSendAbsoluteSenderTimeStatus(int channel,
Do you need to PSA this change to the legacy, but public, API?

[stefan-webrtc, 2016-10-31 15:40:16]

Comments addressed.

[stefan-webrtc, 2016-10-31 15:40:27]

https://codereview.webrtc.org/2455013003/diff/40001/webrtc/audio/audio_receiv...
File webrtc/audio/audio_receive_stream_unittest.cc (left):

https://codereview.webrtc.org/2455013003/diff/40001/webrtc/audio/audio_receiv...
webrtc/audio/audio_receive_stream_unittest.cc:128:
RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
On 2016/10/27 16:09:17, the sun wrote:
> Add audio level instead, and keep the test of ToString().

Audio level is already there. This is unrelated to the ToString() test.

Adding something to ToString test below anyway.

https://codereview.webrtc.org/2455013003/diff/40001/webrtc/voice_engine/chann...
File webrtc/voice_engine/channel_proxy.h (left):

https://codereview.webrtc.org/2455013003/diff/40001/webrtc/voice_engine/chann...
webrtc/voice_engine/channel_proxy.h:55: virtual void
SetSendAbsoluteSenderTimeStatus(bool enable, int id);
On 2016/10/27 16:09:17, the sun wrote:
> There's a mock_channel_proxy which you should update too.

Done.

https://codereview.webrtc.org/2455013003/diff/40001/webrtc/voice_engine/inclu...
File webrtc/voice_engine/include/voe_rtp_rtcp.h (left):

https://codereview.webrtc.org/2455013003/diff/40001/webrtc/voice_engine/inclu...
webrtc/voice_engine/include/voe_rtp_rtcp.h:137: virtual int
SetSendAbsoluteSenderTimeStatus(int channel,
On 2016/10/27 16:09:17, the sun wrote:
> Do you need to PSA this change to the legacy, but public, API?

In theory, yes, but I'm pretty sure it's being unused. I could send a PSA, but I
don't think it's worth waiting 2 weeks...

[the sun, 2016-11-01 08:39:40]

lgtm

https://codereview.webrtc.org/2455013003/diff/40001/webrtc/audio/audio_receiv...
File webrtc/audio/audio_receive_stream_unittest.cc (left):

https://codereview.webrtc.org/2455013003/diff/40001/webrtc/audio/audio_receiv...
webrtc/audio/audio_receive_stream_unittest.cc:128:
RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
On 2016/10/31 15:40:27, stefan-webrtc (holmer) wrote:
> On 2016/10/27 16:09:17, the sun wrote:
> > Add audio level instead, and keep the test of ToString().
> 
> Audio level is already there. This is unrelated to the ToString() test.
> 
> Adding something to ToString test below anyway.

Thank you!

[stefan-webrtc, 2016-11-01 08:41:03]

The CQ bit was checked by stefan@webrtc.org

[commit-bot: I haz the power, 2016-11-01 08:41:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-01 08:42:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 08:42:04]

Try jobs failed on following builders:
  ios32_sim_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/12043)
  ios64_sim_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/12063)
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/14398)
  ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/14284)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/19629)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/18317)

[stefan-webrtc, 2016-11-01 09:53:54]

Rebase.

[stefan-webrtc, 2016-11-01 09:54:08]

The CQ bit was checked by stefan@webrtc.org

[stefan-webrtc, 2016-11-01 09:54:09]

The patchset sent to the CQ was uploaded after l-g-t-m from solenberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2455013003/#ps80001 (title:
"Rebase.")

[commit-bot: I haz the power, 2016-11-01 09:54:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-01 10:17:18]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-01 10:17:25]

Description was changed from

==========
Clean up abs-send-time for audio.

BUG=None
==========

to

==========
Clean up abs-send-time for audio.

BUG=None

Committed: https://crrev.com/b521aa704f75888a68edb6b5b046a0dce7d56f51
Cr-Commit-Position: refs/heads/master@{#14870}
==========

[commit-bot: I haz the power, 2016-11-01 10:17:26]

Patchset 5 (id:??) landed as
https://crrev.com/b521aa704f75888a68edb6b5b046a0dce7d56f51
Cr-Commit-Position: refs/heads/master@{#14870}