Remove voe::Channel::StopReceive() and associated logic.

Remove voe::Channel::StopReceive() and associated logic.

- The legacy API is not used in WVoE/MC.
- Removed use of the API (along with StartReceive()) from unit tests.

BUG=webrtc:4690
Committed: https://crrev.com/e566ac73410b1cc768805c523362ed457fd5f4e0
Cr-Commit-Position: refs/heads/master@{#14858}

[the sun, 2016-10-27 09:32:48]

solenberg@webrtc.org changed reviewers:
+ ossu@webrtc.org

[ossu, 2016-10-27 09:40:56]

https://codereview.webrtc.org/2453243003/diff/1/webrtc/voice_engine/include/v...
File webrtc/voice_engine/include/voe_base.h (right):

https://codereview.webrtc.org/2453243003/diff/1/webrtc/voice_engine/include/v...
webrtc/voice_engine/include/voe_base.h:165: virtual int StartReceive(int
channel) = 0;
If you're removing StopReceive, shouldn't StartReceive go as well? Seems strange
that you can do one thing and not the other.
Also looks like StartReceive is not being called anywhere.

[the sun, 2016-10-27 10:44:02]

https://codereview.webrtc.org/2453243003/diff/1/webrtc/voice_engine/include/v...
File webrtc/voice_engine/include/voe_base.h (right):

https://codereview.webrtc.org/2453243003/diff/1/webrtc/voice_engine/include/v...
webrtc/voice_engine/include/voe_base.h:165: virtual int StartReceive(int
channel) = 0;
On 2016/10/27 09:40:56, ossu wrote:
> If you're removing StopReceive, shouldn't StartReceive go as well? Seems
strange
> that you can do one thing and not the other.
> Also looks like StartReceive is not being called anywhere.

The reason I decided to keep it is that StartReceive() resets the discarded
packet count, which can be retrieved using the VoERTP_RTCP::GetRTPStatistics()
API. StopReceive() didn't have any function from what I could see.

[ossu, 2016-10-27 12:58:37]

lgtm with comments

https://codereview.webrtc.org/2453243003/diff/1/webrtc/voice_engine/include/v...
File webrtc/voice_engine/include/voe_base.h (right):

https://codereview.webrtc.org/2453243003/diff/1/webrtc/voice_engine/include/v...
webrtc/voice_engine/include/voe_base.h:165: virtual int StartReceive(int
channel) = 0;
On 2016/10/27 10:44:02, the sun wrote:
> On 2016/10/27 09:40:56, ossu wrote:
> > If you're removing StopReceive, shouldn't StartReceive go as well? Seems
> strange
> > that you can do one thing and not the other.
> > Also looks like StartReceive is not being called anywhere.
> 
> The reason I decided to keep it is that StartReceive() resets the discarded
> packet count, which can be retrieved using the VoERTP_RTCP::GetRTPStatistics()
> API. StopReceive() didn't have any function from what I could see.

Then I think you should rename it to something like RestartReceive or
ResetDiscardedPacketCount.

[ossu, 2016-10-27 14:24:45]

On 2016/10/27 12:58:37, ossu wrote:
> lgtm with comments
> 
>
https://codereview.webrtc.org/2453243003/diff/1/webrtc/voice_engine/include/v...
> File webrtc/voice_engine/include/voe_base.h (right):
> 
>
https://codereview.webrtc.org/2453243003/diff/1/webrtc/voice_engine/include/v...
> webrtc/voice_engine/include/voe_base.h:165: virtual int StartReceive(int
> channel) = 0;
> On 2016/10/27 10:44:02, the sun wrote:
> > On 2016/10/27 09:40:56, ossu wrote:
> > > If you're removing StopReceive, shouldn't StartReceive go as well? Seems
> > strange
> > > that you can do one thing and not the other.
> > > Also looks like StartReceive is not being called anywhere.
> > 
> > The reason I decided to keep it is that StartReceive() resets the discarded
> > packet count, which can be retrieved using the
VoERTP_RTCP::GetRTPStatistics()
> > API. StopReceive() didn't have any function from what I could see.
> 
> Then I think you should rename it to something like RestartReceive or
> ResetDiscardedPacketCount.

Uhm, the one in Channel, that is. Don't change the VoEBase interface over this.
:)

[the sun, 2016-10-28 07:48:23]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2016-10-28 07:48:23]

The patchset sent to the CQ was uploaded after l-g-t-m from ossu@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2453243003/#ps20001 (title:
"comment")

[commit-bot: I haz the power, 2016-10-28 07:48:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-28 07:50:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 07:50:54]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9621)

[the sun, 2016-10-28 10:55:10]

+kjellander for webrtc/test/

[the sun, 2016-10-28 10:55:56]

-kjellander
+stefan@ for test/ and video/

[the sun, 2016-10-28 10:56:11]

solenberg@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2016-10-31 09:43:49]

lgtm

[the sun, 2016-10-31 19:04:00]

The CQ bit was checked by solenberg@webrtc.org

[commit-bot: I haz the power, 2016-10-31 19:04:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-31 19:52:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-31 20:00:01]

Description was changed from

==========
Remove voe::Channel::StopReceive() and associated logic.

- The legacy API is not used in WVoE/MC.
- Removed use of the API (along with StartReceive()) from unit tests.

BUG=webrtc:4690
==========

to

==========
Remove voe::Channel::StopReceive() and associated logic.

- The legacy API is not used in WVoE/MC.
- Removed use of the API (along with StartReceive()) from unit tests.

BUG=webrtc:4690

Committed: https://crrev.com/e566ac73410b1cc768805c523362ed457fd5f4e0
Cr-Commit-Position: refs/heads/master@{#14858}
==========

[commit-bot: I haz the power, 2016-10-31 20:00:02]

Patchset 2 (id:??) landed as
https://crrev.com/e566ac73410b1cc768805c523362ed457fd5f4e0
Cr-Commit-Position: refs/heads/master@{#14858}