Remove voe::Channel::StopReceive() and associated logic.

webrtc/voice_engine/include/voe_base.h

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 144 matching lines @@
   // Returns channel ID or -1 in case of an error.
   virtual int CreateChannel() = 0;
   virtual int CreateChannel(const ChannelConfig& config) = 0;
 
   // Deletes an existing channel and releases the utilized resources.
   // Returns -1 in case of an error, 0 otherwise.
   virtual int DeleteChannel(int channel) = 0;
 
   // Prepares and initiates the VoiceEngine for reception of
   // incoming RTP/RTCP packets on the specified |channel|.
   virtual int StartReceive(int channel) = 0;

[ossu, 2016/10/27 09:40:56]

If you're removing StopReceive, shouldn't StartReceive go as well? Seems strange
that you can do one thing and not the other.
Also looks like StartReceive is not being called anywhere.

[the sun, 2016/10/27 10:44:02]

The reason I decided to keep it is that StartReceive() resets the discarded
packet count, which can be retrieved using the VoERTP_RTCP::GetRTPStatistics()
API. StopReceive() didn't have any function from what I could see.

[ossu, 2016/10/27 12:58:37]

Then I think you should rename it to something like RestartReceive or
ResetDiscardedPacketCount.

 
   // Stops receiving incoming RTP/RTCP packets on the specified |channel|.
-  virtual int StopReceive(int channel) = 0;
+  virtual int StopReceive(int channel)  { return 0; }
 
   // Starts forwarding the packets to the mixer/soundcard for a
   // specified |channel|.
   virtual int StartPlayout(int channel) = 0;
 
   // Stops forwarding the packets to the mixer/soundcard for a
   // specified |channel|.
   virtual int StopPlayout(int channel) = 0;
 
   // Starts sending packets to an already specified IP address and
@@ skipping 20 matching lines @@
   virtual int AssociateSendChannel(int channel, int accociate_send_channel) = 0;
 
  protected:
   VoEBase() {}
   virtual ~VoEBase() {}
 };
 
 }  // namespace webrtc
 
 #endif  //  WEBRTC_VOICE_ENGINE_VOE_BASE_H