Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2452963002:
Declare VideoCodec.codec_specific_info private (Closed)
|
Created:
4 years, 1 month ago by hta-webrtc Modified:
4 years, 1 month ago CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, mflodman Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionDeclare VideoCodec.codec_specific_info private
This completes the privatization of the codec specific
information in VideoCodec.
BUG=webrtc:6603
Committed: https://crrev.com/792738640234d81c916ac4458ac72286cb2548a4
Cr-Commit-Position: refs/heads/master@{#15013}
Patch Set 1 #Patch Set 2 : Address 2 more instances #Patch Set 3 : Usage of codecSpecific in android JNI found #Patch Set 4 : Another Android compile fail #Patch Set 5 : Rebase #
Messages
Total messages: 46 (35 generated)
Description was changed from ========== Declare VideoCodec.codec_specific_info private This completes the privatization of the codec specific information in VideoCodec. BUG=webrtc:6603 ========== to ========== Declare VideoCodec.codec_specific_info private This completes the privatization of the codec specific information in VideoCodec. BUG=webrtc:6603 ==========
hta@webrtc.org changed reviewers: + magjed@chromium.org, tommi@chromium.org
PTAL. This has to roll into Chrome after https://codereview.chromium.org/2449353003/, but there's no reason not to get the review done.
The CQ bit was checked by hta@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_baremetal/builds/...) linux_libfuzzer_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/bui...) mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)
The CQ bit was checked by hta@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_x86_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_rel...)
The CQ bit was checked by hta@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The target date for submitting this CL is November 9.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_clang_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_clang_dbg/build...)
The CQ bit was checked by hta@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_x64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_dbg/builds/2510)
The CQ bit was checked by hta@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
tommi@webrtc.org changed reviewers: + tommi@webrtc.org
lgtm
The CQ bit was checked by hta@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_more_configs on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_more_configs/bu...) ios32_sim_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/12361) ios64_sim_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/12377) ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/14714) ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/14592) ios_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/19946) ios_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/18639) linux_libfuzzer_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/bui...) linux_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/20032) presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/10026)
The CQ bit was checked by hta@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was checked by hta@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hta@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org, magjed@chromium.org Link to the patchset: https://codereview.webrtc.org/2452963002/#ps80001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Declare VideoCodec.codec_specific_info private This completes the privatization of the codec specific information in VideoCodec. BUG=webrtc:6603 ========== to ========== Declare VideoCodec.codec_specific_info private This completes the privatization of the codec specific information in VideoCodec. BUG=webrtc:6603 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Declare VideoCodec.codec_specific_info private This completes the privatization of the codec specific information in VideoCodec. BUG=webrtc:6603 ========== to ========== Declare VideoCodec.codec_specific_info private This completes the privatization of the codec specific information in VideoCodec. BUG=webrtc:6603 Committed: https://crrev.com/792738640234d81c916ac4458ac72286cb2548a4 Cr-Commit-Position: refs/heads/master@{#15013} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/792738640234d81c916ac4458ac72286cb2548a4 Cr-Commit-Position: refs/heads/master@{#15013}
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.webrtc.org/2491933002/ by hta@webrtc.org. The reason for reverting is: Broke a google3 build .
Message was sent while issue was closed.
On 2016/11/10 16:36:39, hta-webrtc wrote: > A revert of this CL (patchset #5 id:80001) has been created in > https://codereview.webrtc.org/2491933002/ by mailto:hta@webrtc.org. > > The reason for reverting is: Broke a google3 build > . The particular build that was broken: http://webrtc-buildbot-master.mtv.corp.google.com:21000/builders/WebRTC%20goo... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
