Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: webrtc/config.cc

Issue 2452963002: Declare VideoCodec.codec_specific_info private (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/common_types.cc ('k') | webrtc/video/vie_encoder.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include "webrtc/config.h" 10 #include "webrtc/config.h"
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 ss << ", min_transmit_bitrate_bps: " << min_transmit_bitrate_bps; 160 ss << ", min_transmit_bitrate_bps: " << min_transmit_bitrate_bps;
161 ss << '}'; 161 ss << '}';
162 return ss.str(); 162 return ss.str();
163 } 163 }
164 164
165 VideoEncoderConfig::VideoEncoderConfig(const VideoEncoderConfig&) = default; 165 VideoEncoderConfig::VideoEncoderConfig(const VideoEncoderConfig&) = default;
166 166
167 void VideoEncoderConfig::EncoderSpecificSettings::FillEncoderSpecificSettings( 167 void VideoEncoderConfig::EncoderSpecificSettings::FillEncoderSpecificSettings(
168 VideoCodec* codec) const { 168 VideoCodec* codec) const {
169 if (codec->codecType == kVideoCodecH264) { 169 if (codec->codecType == kVideoCodecH264) {
170 FillVideoCodecH264(&codec->codecSpecific.H264); 170 FillVideoCodecH264(codec->H264());
171 } else if (codec->codecType == kVideoCodecVP8) { 171 } else if (codec->codecType == kVideoCodecVP8) {
172 FillVideoCodecVp8(&codec->codecSpecific.VP8); 172 FillVideoCodecVp8(codec->VP8());
173 } else if (codec->codecType == kVideoCodecVP9) { 173 } else if (codec->codecType == kVideoCodecVP9) {
174 FillVideoCodecVp9(&codec->codecSpecific.VP9); 174 FillVideoCodecVp9(codec->VP9());
175 } else { 175 } else {
176 RTC_NOTREACHED() << "Encoder specifics set/used for unknown codec type."; 176 RTC_NOTREACHED() << "Encoder specifics set/used for unknown codec type.";
177 } 177 }
178 } 178 }
179 179
180 void VideoEncoderConfig::EncoderSpecificSettings::FillVideoCodecH264( 180 void VideoEncoderConfig::EncoderSpecificSettings::FillVideoCodecH264(
181 VideoCodecH264* h264_settings) const { 181 VideoCodecH264* h264_settings) const {
182 RTC_NOTREACHED(); 182 RTC_NOTREACHED();
183 } 183 }
184 184
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 void VideoEncoderConfig::Vp9EncoderSpecificSettings::FillVideoCodecVp9( 217 void VideoEncoderConfig::Vp9EncoderSpecificSettings::FillVideoCodecVp9(
218 VideoCodecVP9* vp9_settings) const { 218 VideoCodecVP9* vp9_settings) const {
219 *vp9_settings = specifics_; 219 *vp9_settings = specifics_;
220 } 220 }
221 221
222 DecoderSpecificSettings::DecoderSpecificSettings() = default; 222 DecoderSpecificSettings::DecoderSpecificSettings() = default;
223 223
224 DecoderSpecificSettings::~DecoderSpecificSettings() = default; 224 DecoderSpecificSettings::~DecoderSpecificSettings() = default;
225 225
226 } // namespace webrtc 226 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/common_types.cc ('k') | webrtc/video/vie_encoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698