Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Unified Diff: webrtc/modules/desktop_capture/window_capturer.h

Issue 2452263003: Add DesktopCapturer GetSourceList SelectSource FocusOnSelectedSource functions (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/desktop_capture/window_capturer.h
diff --git a/webrtc/modules/desktop_capture/window_capturer.h b/webrtc/modules/desktop_capture/window_capturer.h
index 682778c5586126903ebc4464716f0cf95f87dcb8..d5d84ee13790b32fb31c0b96e5a5fa4333e19144 100644
--- a/webrtc/modules/desktop_capture/window_capturer.h
+++ b/webrtc/modules/desktop_capture/window_capturer.h
@@ -23,9 +23,10 @@ namespace webrtc {
class DesktopCaptureOptions;
+// TODO(zijiehe): Remove this class.
class WindowCapturer : public DesktopCapturer {
public:
- typedef webrtc::WindowId WindowId;
+ typedef DesktopCapturer::WindowId WindowId;
struct Window {
WindowId id;
@@ -36,20 +37,29 @@ class WindowCapturer : public DesktopCapturer {
typedef std::vector<Window> WindowList;
+ // Consumers should use DesktopCapturer::CreateWindowCapturer.
static WindowCapturer* Create(const DesktopCaptureOptions& options);
- ~WindowCapturer() override {}
+ ~WindowCapturer() override;
+ // Deprecated, use GetSourceList().
// Get list of windows. Returns false in case of a failure.
- virtual bool GetWindowList(WindowList* windows) = 0;
+ virtual bool GetWindowList(WindowList* windows);
+ // Deprecated, use SelectSource().
// Select window to be captured. Returns false in case of a failure (e.g. if
// there is no window with the specified id).
- virtual bool SelectWindow(WindowId id) = 0;
+ virtual bool SelectWindow(WindowId id);
+ // Deprecated, use FocusOnSelectedSource().
// Bring the selected window to the front. Returns false in case of a
// failure or no window selected.
- virtual bool BringSelectedWindowToFront() = 0;
+ virtual bool BringSelectedWindowToFront();
+
+ // DesktopCapturer interfaces.
+ bool GetSourceList(SourceList* sources) override;
+ bool SelectSource(const Source& source) override;
+ bool FocusOnSelectedSource() override;
};
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698