Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: webrtc/modules/desktop_capture/screen_capturer.h

Issue 2452263003: Add DesktopCapturer GetSourceList SelectSource FocusOnSelectedSource functions (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/desktop_capture/screen_capturer.h
diff --git a/webrtc/modules/desktop_capture/screen_capturer.h b/webrtc/modules/desktop_capture/screen_capturer.h
index 5f07ba1a53318986a6a4af20a2d5730ba05196b8..d88818adf9d82966a57fd3ebd483317b4c891f50 100644
--- a/webrtc/modules/desktop_capture/screen_capturer.h
+++ b/webrtc/modules/desktop_capture/screen_capturer.h
@@ -21,6 +21,7 @@ namespace webrtc {
class DesktopCaptureOptions;
+// TODO(zijiehe): Remove this class.
// Class used to capture video frames asynchronously.
//
// The full capture sequence is as follows:
@@ -41,6 +42,8 @@ class DesktopCaptureOptions;
// Since data can be read while another capture action is happening.
class ScreenCapturer : public DesktopCapturer {
public:
+ typedef DesktopCapturer::ScreenId ScreenId;
+
// Use a struct to represent a screen although it has only an id for now,
// because we may want to add more fields (e.g. description) in the future.
struct Screen {
@@ -48,19 +51,25 @@ class ScreenCapturer : public DesktopCapturer {
};
typedef std::vector<Screen> ScreenList;
- ~ScreenCapturer() override {}
+ ~ScreenCapturer() override;
// Creates a platform-specific capturer.
static ScreenCapturer* Create(const DesktopCaptureOptions& options);
+ // Deprecated, use GetSourceList.
Sergey Ulanov 2016/10/28 15:53:22 nit: s/GetSourceList/GetSourceList()/
Hzj_jie 2016/10/28 22:03:53 Done.
// Get the list of screens (not containing kFullDesktopScreenId). Returns
// false in case of a failure.
- virtual bool GetScreenList(ScreenList* screens) = 0;
+ virtual bool GetScreenList(ScreenList* screens);
+ // Deprecated, use SelectSource.
Sergey Ulanov 2016/10/28 15:53:22 SelectSource()
Hzj_jie 2016/10/28 22:03:53 Done.
// Select the screen to be captured. Returns false in case of a failure (e.g.
// if there is no screen with the specified id). If this is never called, the
// full desktop is captured.
- virtual bool SelectScreen(ScreenId id) = 0;
+ virtual bool SelectScreen(ScreenId id);
+
+ // DesktopCapturer interfaces.
+ bool GetSourceList(SourceList* sources) override;
+ bool SelectSource(const Source& source) override;
};
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698