Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2450953002: Change destruction order to fix potential invalid pointer dereference. (Closed)

Created:
4 years, 1 month ago by erikchen
Modified:
4 years, 1 month ago
Reviewers:
Sergey Ulanov
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change destruction order to fix potential invalid pointer dereference. BUG=657226 Committed: https://crrev.com/54b0acb432b3cd4a20403862e2ed3ef33ae85c0f Cr-Commit-Position: refs/heads/master@{#14792}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/modules/desktop_capture/screen_capturer_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
erikchen
sergeyu: Please review.
4 years, 1 month ago (2016-10-25 19:55:58 UTC) #8
Sergey Ulanov
lgtm
4 years, 1 month ago (2016-10-26 16:59:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2450953002/1
4 years, 1 month ago (2016-10-26 17:03:34 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 18:10:28 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 18:21:49 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54b0acb432b3cd4a20403862e2ed3ef33ae85c0f
Cr-Commit-Position: refs/heads/master@{#14792}

Powered by Google App Engine
This is Rietveld 408576698