Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: webrtc/modules/desktop_capture/screen_capturer_mac.mm

Issue 2450953002: Change destruction order to fix potential invalid pointer dereference. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/desktop_capture/screen_capturer_mac.mm
diff --git a/webrtc/modules/desktop_capture/screen_capturer_mac.mm b/webrtc/modules/desktop_capture/screen_capturer_mac.mm
index 47885ee9d9d281fdb8b5019c8e59bf99343d14d4..3251e5a06509fc09aa37955f1302c444d3b22105 100644
--- a/webrtc/modules/desktop_capture/screen_capturer_mac.mm
+++ b/webrtc/modules/desktop_capture/screen_capturer_mac.mm
@@ -390,8 +390,8 @@ ScreenCapturerMac::ScreenCapturerMac(
ScreenCapturerMac::~ScreenCapturerMac() {
ReleaseBuffers();
- display_stream_manager_->PrepareForSelfDestruction();
UnregisterRefreshAndMoveHandlers();
+ display_stream_manager_->PrepareForSelfDestruction();
dlclose(app_services_library_);
dlclose(opengl_library_);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698