Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2448983002: offsetParent() fails to consider continuations when searching for the parent. (Closed)

Created:
4 years, 1 month ago by Karl Øygard
Modified:
3 years, 3 months ago
Reviewers:
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

offsetParent() fails to consider continuations when searching for the parent. Block-level objects can have inline parents, but this triggers the insertion of anonymous boxes and continuations, which offsetParent() currently doesn't understand. This change lets offsetParent() understand continuations better. If an anonymous continuation is encountered when finding ancestors, it will use the split inline as the ancestor, and continue searching from there. BUG=638177

Patch Set 1 #

Patch Set 2 : Added test case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/inline/inline-offsetParent-continuation.html View 1 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 1 chunk +14 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (9 generated)
Karl Øygard
The CQ bit was checked by karlo@opera.com to run a CQ dry run
4 years, 1 month ago (2016-10-25 11:57:01 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448983002/1
4 years, 1 month ago (2016-10-25 11:57:17 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-10-25 13:02:28 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 1 month ago (2016-10-25 13:02:28 UTC) #4
Karl Øygard
Description was changed from ========== offsetParent() failed to consider continuations when searching for the parent. ...
4 years, 1 month ago (2016-10-26 08:41:56 UTC) #5
Karl Øygard
The CQ bit was checked by karlo@opera.com to run a CQ dry run
4 years, 1 month ago (2016-10-28 07:50:32 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448983002/20001
4 years, 1 month ago (2016-10-28 07:50:42 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-10-28 09:01:06 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 09:01:07 UTC) #9
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698