Rename {,Set}GenericFECStatus to {,Set}UlpfecConfig.

webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

Index: webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
diff --git a/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h b/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
index 9fa3959c906128a81596a7fc8f97e9a269167bbc..772ed07409b8978270e9d1b833d1aa33bed0a8ec 100644
--- a/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
+++ b/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h
@@ -454,14 +454,14 @@ class RtpRtcp : public Module {
   // **************************************************************************
 
   // Turn on/off generic FEC.

[danilchap, 2016/10/26 12:59:13]

update comments too.

[brandtr, 2016/10/26 13:57:04]

Done.

-  virtual void SetGenericFECStatus(bool enable,
-                                   uint8_t payload_type_red,
-                                   uint8_t payload_type_fec) = 0;
+  virtual void SetUlpfecConfig(bool ulpfec_enabled,

[danilchap, 2016/10/26 12:59:13]

since function already called UlpfecConfig, 'ulpfec_' prefix in this variable
name feels a bit redundant.
May be remove it (call just 'enable')
(this comment doesn't apply to payload_type since there are two payload type, so
prefix is helpful to distinguish them)

[brandtr, 2016/10/26 13:57:04]

Done. (This parameter will probably removed soon though!)

+                               int red_payload_type,
+                               int ulpfec_payload_type) = 0;
 
   // Get generic FEC setting.
-  virtual void GenericFECStatus(bool* enable,
-                                uint8_t* payload_type_red,
-                                uint8_t* payload_type_fec) = 0;
+  virtual void UlpfecConfig(bool* ulpfec_enabled,

[danilchap, 2016/10/26 12:59:13]

It seems this function is not in use any more. (e.g. no use of it updated in
this CL)
May be just delete it.

[brandtr, 2016/10/26 13:57:04]

Ah, I wasn't careful enough in checking where this function is used. It's only
the implementation living in RTPSenderVideo that is actually called, so no need
to have it part of this general interface.

+                            int* red_payload_type,
+                            int* ulpfec_payload_type) = 0;
 
   virtual int32_t SetFecParameters(const FecProtectionParams* delta_params,
                                    const FecProtectionParams* key_params) = 0;