Rename {,Set}GenericFECStatus to {,Set}UlpfecConfig.

webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 435 matching lines @@
   // indication.
   // This API shall be called before transmision of an RTP packet to ensure
   // that the |level| part of the extended RTP header is updated.
   // return -1 on failure else 0.
   virtual int32_t SetAudioLevel(uint8_t level_dbov) = 0;
 
   // **************************************************************************
   // Video
   // **************************************************************************
 
   // Turn on/off generic FEC.

[danilchap, 2016/10/26 12:59:13]

update comments too.

[brandtr, 2016/10/26 13:57:04]

Done.

-  virtual void SetGenericFECStatus(bool enable,
-                                   uint8_t payload_type_red,
-                                   uint8_t payload_type_fec) = 0;
+  virtual void SetUlpfecConfig(bool ulpfec_enabled,

[danilchap, 2016/10/26 12:59:13]

since function already called UlpfecConfig, 'ulpfec_' prefix in this variable
name feels a bit redundant.
May be remove it (call just 'enable')
(this comment doesn't apply to payload_type since there are two payload type, so
prefix is helpful to distinguish them)

[brandtr, 2016/10/26 13:57:04]

Done. (This parameter will probably removed soon though!)

+                               int red_payload_type,
+                               int ulpfec_payload_type) = 0;
 
   // Get generic FEC setting.
-  virtual void GenericFECStatus(bool* enable,
-                                uint8_t* payload_type_red,
-                                uint8_t* payload_type_fec) = 0;
+  virtual void UlpfecConfig(bool* ulpfec_enabled,

[danilchap, 2016/10/26 12:59:13]

It seems this function is not in use any more. (e.g. no use of it updated in
this CL)
May be just delete it.

[brandtr, 2016/10/26 13:57:04]

Ah, I wasn't careful enough in checking where this function is used. It's only
the implementation living in RTPSenderVideo that is actually called, so no need
to have it part of this general interface.

+                            int* red_payload_type,
+                            int* ulpfec_payload_type) = 0;
 
   virtual int32_t SetFecParameters(const FecProtectionParams* delta_params,
                                    const FecProtectionParams* key_params) = 0;
 
   // Set method for requestion a new key frame.
   // Returns -1 on failure else 0.
   virtual int32_t SetKeyFrameRequestMethod(KeyFrameRequestMethod method) = 0;
 
   // Sends a request for a keyframe.
   // Returns -1 on failure else 0.
   virtual int32_t RequestKeyFrame() = 0;
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_